PLEX-2791 N-06 Improve LogPoller Heath Observability#436
Open
dhaidashenko wants to merge 1 commit intofix/plex-2783-l-05-fix-missed-finality-violation-in-case-of-empty-blockfrom
Conversation
Contributor
✅ API Diff Results - No breaking changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
batchInsert Retry Path Can Silently Repeat Failed Persistence
The ORM batchInsert helper only shrinks the batch size when the returned error matches context.DeadlineExceeded and never below 500 rows. If a large insert fails for a size-sensitive database reason that does not surface as DeadlineExceeded, batchInsert returns the error immediately even though smaller sub-batches might succeed. Since the pollAndSaveLog function treats insert failures as retry-later and the main loop resumes from SelectLatestBlock+1, the poller can repeatedly recreate the same failing insert shape and stall ingestion progress.
Fix
Expose a general metric that signals if LogPoller is stuck.