Skip to content

Conversation

@connorwstein
Copy link
Contributor

@connorwstein connorwstein commented Jan 14, 2026

The full keystore (with Admin which has write capabilities) isn't needed, we can reduce scope to readonly and that allows us to plug in KMS impls which can't have an Admin implementation.

Note while technically a breaking change this won't break callers

@github-actions
Copy link
Contributor

github-actions bot commented Jan 14, 2026

⚠️ API Diff Results - Breaking changes detected

📦 Module: github-com-smartcontractkit-chainlink-evm

🔴 Breaking Changes (2)

pkg/keys/v2 (2)
  • GetTxKeys — Type changed:
func(
  context.Context, 
  - github.com/smartcontractkit/chainlink-common/keystore.Keystore, 
  + interface{github.com/smartcontractkit/chainlink-common/keystore.Reader; github.com/smartcontractkit/chainlink-common/keystore.Signer}, 
  []string
)
([]*TxKey, error)
  • NewTxKeyCoreKeystore — Type changed:
func(
  - github.com/smartcontractkit/chainlink-common/keystore.Keystore
  + interface{github.com/smartcontractkit/chainlink-common/keystore.Reader; github.com/smartcontractkit/chainlink-common/keystore.Signer}, 
  + ...Option
)
*TxKeyCoreKeystore

📄 View full apidiff report

@connorwstein connorwstein marked this pull request as ready for review January 14, 2026 19:31
@connorwstein connorwstein requested a review from a team as a code owner January 14, 2026 19:31
@connorwstein connorwstein merged commit 45999db into develop Jan 14, 2026
33 checks passed
@connorwstein connorwstein deleted the ARCH-332-kms branch January 14, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants