PLEX-2391: MultiNode: reduce duration of FinalizedOutOfSync #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhaidashenko
previously approved these changes
Jan 14, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces the duration of the FinalizedOutOfSync condition in multi-node setups by pre-fetching the latest block during health-check requests before establishing WebSocket subscriptions. This ensures the node's latest observation is current even if WebSocket head delivery is delayed.
Changes:
- Added pre-fetch logic in
SubscribeToHeadsto fetch the latest block before WS subscription when handling health-check requests - Added test coverage to verify that health-check pre-fetch updates latest block info before any WS messages arrive
- Fixed typo in comment: "SubscribeToheads" → "SubscribeToHeads"
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/client/rpc_client.go | Added pre-fetch block logic for health-check requests and corrected method name typo in comment |
| pkg/client/rpc_client_test.go | Added test case verifying pre-fetch behavior updates latest block before WS messages |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
✅ API Diff Results - No breaking changes |
dhaidashenko
previously approved these changes
Jan 14, 2026
dhaidashenko
approved these changes
Jan 14, 2026
ilija42
approved these changes
Jan 14, 2026
This was referenced Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira: https://smartcontract-it.atlassian.net/browse/PLEX-2391