Insert and Trim in Batches for HeadTracker ORM #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
👋 yashnevatia, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
yashnevatia
changed the title
pkg/heads/orm.go
Outdated
| for i, head := range heads { | ||
| offset := i * 7 | ||
| placeholders = append(placeholders, | ||
| fmt.Sprintf("($%d, $%d, $%d, now(), $%d, $%d, $%d, $%d)", |
Contributor
There was a problem hiding this comment.
This seems error-prone. It might be better to use NamedExecContext. Example:
chainlink-evm/pkg/logpoller/orm.go
Line 580 in 45280ea
dhaidashenko
previously approved these changes
Jul 10, 2025
Unheilbar
approved these changes
Jul 10, 2025
dhaidashenko
approved these changes
Jul 10, 2025
ilija42
approved these changes
Jul 10, 2025
yashnevatia
added a commit
that referenced
this pull request
Jul 15, 2025
This reverts commit ea9dd76.
yashnevatia
added a commit
that referenced
this pull request
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HeadTracker insert/deletes are very heavy on the db because its being done per block.
We are trying to batch it here to make it more efficient.
Slack thread -> https://chainlink-core.slack.com/archives/C07PHTC2WJC/p1751473048720999
Ticket: