Skip to content

test(operations): added more test for WithIdempotencyKey#1018

Merged
graham-chainlink merged 1 commit into
mainfrom
ggoh/cld-2579/test-extra
May 29, 2026
Merged

test(operations): added more test for WithIdempotencyKey#1018
graham-chainlink merged 1 commit into
mainfrom
ggoh/cld-2579/test-extra

Conversation

@graham-chainlink
Copy link
Copy Markdown
Collaborator

Added test cases when idempotency key is used , it should be included in the report

JIRA: https://smartcontract-it.atlassian.net/browse/CLD-2579

Added test cases when idempotency key is used , it should be included in the report

JIRA: https://smartcontract-it.atlassian.net/browse/CLD-2579
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 29, 2026

⚠️ No Changeset found

Latest commit: 34480f0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graham-chainlink graham-chainlink marked this pull request as ready for review May 29, 2026 09:33
@graham-chainlink graham-chainlink requested a review from a team as a code owner May 29, 2026 09:33
Copilot AI review requested due to automatic review settings May 29, 2026 09:33
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds focused JSON serialization tests for the IdempotencyKey field on operation reports, verifying it is present when set via WithIdempotencyKey and omitted otherwise.

Changes:

  • New test Test_ExecuteOperation_ReportJSON_IdempotencyKey with two subtests covering presence and omission of the idempotencyKey JSON field.
  • Adds encoding/json import.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@cl-sonarqube-production
Copy link
Copy Markdown

@graham-chainlink graham-chainlink added this pull request to the merge queue May 29, 2026
Merged via the queue into main with commit 9664409 May 29, 2026
30 checks passed
@graham-chainlink graham-chainlink deleted the ggoh/cld-2579/test-extra branch May 29, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants