Chip Ingress - New Batch API#2031
Open
tarcisiozf wants to merge 3 commits intomainfrom
Open
Conversation
|
👋 tarcisiozf, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
73b6745 to
7051612
Compare
✅ API Diff Results -
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds batch-level publish controls and per-event error reporting to the Chip Ingress protobuf API, exposing the new types through the chipingress Go package.
Changes:
- Introduces
PublishOptionsand attaches it toCloudEventBatchto allow configuring batch atomicity. - Extends
PublishResultwith a per-eventgoogle.rpc.Statuserror field for partial-success scenarios. - Exposes
PublishOptionsvia a Go type alias inpkg/chipingress/types.goand regenerates protobuf Go bindings.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| pkg/chipingress/types.go | Exposes the new protobuf PublishOptions type through the package-level aliases. |
| pkg/chipingress/pb/chip_ingress.proto | Adds PublishOptions, adds batch options, and adds per-result google.rpc.Status error. |
| pkg/chipingress/pb/chip_ingress.pb.go | Regenerated Go bindings reflecting the new protobuf messages/fields and imports. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
DylanTinianov
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CRE-3936