Skip to content

Chip Ingress - New Batch API#2031

Open
tarcisiozf wants to merge 3 commits intomainfrom
batch-chip-proto
Open

Chip Ingress - New Batch API#2031
tarcisiozf wants to merge 3 commits intomainfrom
batch-chip-proto

Conversation

@tarcisiozf
Copy link
Copy Markdown

@tarcisiozf tarcisiozf commented May 5, 2026

Copilot AI review requested due to automatic review settings May 5, 2026 13:16
@tarcisiozf tarcisiozf requested a review from a team as a code owner May 5, 2026 13:16
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

👋 tarcisiozf, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

✅ API Diff Results - github.com/smartcontractkit/chainlink-common/pkg/chipingress

✅ Compatible Changes (6)

./ (1)
  • PublishOptions — ➕ Added
pb (1)
  • PublishOptions — ➕ Added
pb.(*CloudEventBatch) (1)
  • GetOptions — ➕ Added
pb.(*PublishResult) (1)
  • GetError — ➕ Added
pb.CloudEventBatch (1)
  • Options — ➕ Added
pb.PublishResult (1)
  • Error — ➕ Added

📄 View full apidiff report

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds batch-level publish controls and per-event error reporting to the Chip Ingress protobuf API, exposing the new types through the chipingress Go package.

Changes:

  • Introduces PublishOptions and attaches it to CloudEventBatch to allow configuring batch atomicity.
  • Extends PublishResult with a per-event google.rpc.Status error field for partial-success scenarios.
  • Exposes PublishOptions via a Go type alias in pkg/chipingress/types.go and regenerates protobuf Go bindings.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
pkg/chipingress/types.go Exposes the new protobuf PublishOptions type through the package-level aliases.
pkg/chipingress/pb/chip_ingress.proto Adds PublishOptions, adds batch options, and adds per-result google.rpc.Status error.
pkg/chipingress/pb/chip_ingress.pb.go Regenerated Go bindings reflecting the new protobuf messages/fields and imports.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pkg/chipingress/pb/chip_ingress.proto
Comment thread pkg/chipingress/pb/chip_ingress.proto Outdated
Comment thread pkg/chipingress/pb/chip_ingress.proto Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants