ChIP Durable Emitter#1911
Open
DylanTinianov wants to merge 39 commits intomainfrom
Open
Conversation
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
had a problem deploying
to
integration
GitHub Actions
Failure
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
had a problem deploying
to
integration
GitHub Actions
Failure
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
had a problem deploying
to
integration
GitHub Actions
Failure
DylanTinianov
had a problem deploying
to
integration
GitHub Actions
Failure
DylanTinianov
had a problem deploying
to
integration
GitHub Actions
Failure
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
had a problem deploying
to
integration
GitHub Actions
Failure
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
had a problem deploying
to
integration
GitHub Actions
Failure
DylanTinianov
had a problem deploying
to
integration
GitHub Actions
Failure
DylanTinianov
had a problem deploying
to
integration
GitHub Actions
Failure
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
force-pushed
the
durable-emitter-poc
branch
from
5f7ace8 to
a268cb0
Compare
DylanTinianov
had a problem deploying
to
integration
GitHub Actions
Failure
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
had a problem deploying
to
integration
GitHub Actions
Failure
DylanTinianov
had a problem deploying
to
integration
GitHub Actions
Error
DylanTinianov
had a problem deploying
to
integration
GitHub Actions
Failure
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
✅ API Diff Results -
|
…inlink-common into durable-emitter-poc
tarcisiozf
reviewed
May 3, 2026
| d.metrics.publishBatchEvOK.Add(context.Background(), int64(len(batch))) | ||
| } | ||
|
|
||
| // Async MarkDelivered: the DB UPDATE runs in a background goroutine so |
There was a problem hiding this comment.
due to its async nature, is there a risk that a call to ListPending creates rework of tasks because this is in-flight?
Contributor
Author
There was a problem hiding this comment.
Yeah async mark implies ListPending can still see those rows and re-enqueue them until mark lands, which is a tradeoff. Not a big deal since we guarantee at least once delivery.
We can fix this in a follow-up PR
| // avoiding send vs close races on publishCh. | ||
| func (d *DurableEmitter) Close() error { | ||
| close(d.stopCh) | ||
| if d.insertCh != nil { |
There was a problem hiding this comment.
should we drain insertCh as a graceful shutdown?
|
|
||
| // rawConn is the underlying gRPC connection when the client exposes it. | ||
| // Non-nil enables zero-copy batch publishing (protowire + ForceCodec). | ||
| rawConn *grpc.ClientConn |
Contributor
There was a problem hiding this comment.
Can we still fit into the interface if we consider implementing the emitter with a pool of conns?
There was a problem hiding this comment.
maybe we should do a first version without raw grpc calls and leave as a future optimization option
Contributor
Author
There was a problem hiding this comment.
That should be doable, probably not necessary for now though
jmank88
reviewed
May 5, 2026
jmank88
reviewed
May 5, 2026
jmank88
reviewed
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates ChIP
DurableEmitterto persist and re-send Chip messages.DurableEmitter Integration Testing + ORM