Add teeattestation package for TEE attestation validation by nadahalli · Pull Request #1899 · smartcontractkit/chainlink-common

nadahalli · 2026-03-16T17:24:37Z

Summary

Adds pkg/teeattestation/ with platform-agnostic domain-separated hashing (DomainHash)
Adds pkg/teeattestation/nitro/ with AWS Nitro attestation validation (ValidateAttestation, PCR types, default CA roots)
Adds pkg/teeattestation/nitro/fake/ with FakeAttestor for testing without Nitro hardware
New dependency: github.com/hf/nitrite (Nitro attestation verifier)

Nitro-specific code is isolated in nitro/ so GCP Confidential Computing etc. can be added as sibling packages later.

Used by both confidential-compute (enclave-side) and chainlink (relay DON handler) for attestation validation and domain-separated hashing.

github-actions · 2026-03-16T17:24:53Z

👋 nadahalli, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

Copilot

Pull request overview

Adds a new teeattestation package providing platform-agnostic domain-separated hashing and AWS Nitro Enclave attestation validation, along with a fake attestor for testing.

Changes:

Introduces pkg/teeattestation/hash.go with DomainHash for domain-separated SHA-256 hashing
Adds pkg/teeattestation/nitro/validate.go with ValidateAttestation for verifying AWS Nitro attestation documents against expected PCRs and user data
Adds pkg/teeattestation/nitro/fake/ with a FakeAttestor that produces COSE Sign1 documents verifiable without real Nitro hardware

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
pkg/teeattestation/hash.go	Domain-separated SHA-256 hashing primitive
pkg/teeattestation/hash_test.go	Tests for `DomainHash`
pkg/teeattestation/nitro/validate.go	AWS Nitro attestation validation with PCR and user data checks
pkg/teeattestation/nitro/fake/fake.go	Fake attestor producing valid COSE Sign1 docs for testing
pkg/teeattestation/nitro/fake/fake_test.go	Tests for `FakeAttestor`
go.mod	Adds `github.com/hf/nitrite` dependency

Comments suppressed due to low confidence (1)

pkg/teeattestation/nitro/validate.go:1

The cosePayload struct has an Unprotected field of type cbor.RawMessage, but it is not set when constructing outer in fake.go (line 147). CBOR nil/zero-value for RawMessage may serialize differently than the empty CBOR map ({}) that COSE Sign1 expects for the unprotected header. If nitrite.Verify is strict about this, it could fail. This comment applies to fake.go line 147, referencing the struct in the same file.

// Package nitro provides AWS Nitro Enclave attestation validation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

nadahalli · 2026-03-16T17:30:25Z

pkg/teeattestation/nitro/validate.go

+
+// ValidateAttestation verifies an AWS Nitro attestation document against
+// expected user data and trusted PCR measurements.
+func ValidateAttestation(attestation, expectedUserData, trustedMeasurements []byte, caRootsPEM string) error {


Intentional. Empty string means 'use production default'. All existing callers pass empty string for production and a non-empty PEM for tests. Changing this would break the ergonomics for no practical gain.

nadahalli · 2026-03-16T17:30:26Z

pkg/teeattestation/nitro/validate.go

+	if !bytes.Equal(result.Document.PCRs[0], trustedPCRs.PCR0) {
+		return fmt.Errorf("expected PCR0 %x, got %x", trustedPCRs.PCR0, result.Document.PCRs[0])
+	}
+	if !bytes.Equal(result.Document.PCRs[1], trustedPCRs.PCR1) {
+		return fmt.Errorf("expected PCR1 %x, got %x", trustedPCRs.PCR1, result.Document.PCRs[1])
+	}
+	if !bytes.Equal(result.Document.PCRs[2], trustedPCRs.PCR2) {
+		return fmt.Errorf("expected PCR2 %x, got %x", trustedPCRs.PCR2, result.Document.PCRs[2])
+	}


Fixed. Error messages now only show the expected value.

nadahalli · 2026-03-16T17:30:27Z

pkg/teeattestation/nitro/fake/fake.go

+		"pcr1": hex.EncodeToString(f.pcrs[1]),
+		"pcr2": hex.EncodeToString(f.pcrs[2]),
+	}
+	b, _ := json.Marshal(m)


Added a comment. Changing the signature would break callers for an error that can't happen (json.Marshal on map[string]string).

nadahalli · 2026-03-16T17:30:28Z

pkg/teeattestation/nitro/fake/fake_test.go

+func TestFakeAttestor_RoundTrip(t *testing.T) {
+	fa, err := NewFakeAttestor()
+	require.NoError(t, err)
+
+	userData := []byte("test-user-data-12345")
+	attestation, err := fa.CreateAttestation(userData)
+	require.NoError(t, err)
+	require.NotEmpty(t, attestation)
+
+	result, err := nitrite.Verify(attestation, nitrite.VerifyOptions{
+		CurrentTime: time.Now(),
+		Roots:       fa.CARoots(),
+	})
+	require.NoError(t, err)
+	require.True(t, result.SignatureOK, "ECDSA signature should be valid")
+	require.Equal(t, userData, result.Document.UserData)


Added. validate_test.go now has three integration tests using FakeAttestor + ValidateAttestation: success, wrong user data, wrong PCRs.

vreff · 2026-03-16T17:34:44Z

pkg/teeattestation/nitro/validate.go

+
+// ValidateAttestation verifies an AWS Nitro attestation document against
+// expected user data and trusted PCR measurements.
+func ValidateAttestation(attestation, expectedUserData, trustedMeasurements []byte, caRootsPEM string) error {


nit: rename to ValidateNitroAttestation

It's inside the nitro folder. That should be enough, no?

Ah, yeah. Forgot about that.

vreff · 2026-03-16T17:35:32Z

Would be nice to put this behind a /privacy/ or /confidential-compute/ root package and mark that thing as being Privacy codeowners. That way we can maintain better autonomy for approvals.

nadahalli · 2026-03-16T18:43:37Z

Would be nice to put this behind a /privacy/ or /confidential-compute/ root package and mark that thing as being Privacy codeowners. That way we can maintain better autonomy for approvals.

Let's add privacy as the owner of this folder. I don't want to add a privacy specific top-level package.

vreff · 2026-03-16T19:08:56Z

Let's add privacy as the owner of this folder. I don't want to add a privacy specific top-level package.

sure

nadahalli requested a review from a team as a code owner March 16, 2026 17:24

Copilot AI review requested due to automatic review settings March 16, 2026 17:24

product-security-plaid-production bot requested a review from pavel-raykov March 16, 2026 17:24

nadahalli force-pushed the tejaswi/tee-attestation branch from 0ea8118 to 2edce5f Compare March 16, 2026 17:26

Copilot AI reviewed Mar 16, 2026

View reviewed changes

nadahalli had a problem deploying to integration March 16, 2026 17:26 — with GitHub Actions Error

nadahalli force-pushed the tejaswi/tee-attestation branch from 2edce5f to f9dede0 Compare March 16, 2026 17:27

Add teeattestation package for TEE attestation validation

2c727f6

nadahalli force-pushed the tejaswi/tee-attestation branch from f9dede0 to 2c727f6 Compare March 16, 2026 17:29

nadahalli requested a review from a team March 16, 2026 17:32

vreff reviewed Mar 16, 2026

View reviewed changes

vreff approved these changes Mar 16, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add teeattestation package for TEE attestation validation#1899

Add teeattestation package for TEE attestation validation#1899
nadahalli wants to merge 1 commit intomainfrom
tejaswi/tee-attestation

nadahalli commented Mar 16, 2026

Uh oh!

github-actions bot commented Mar 16, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

nadahalli Mar 16, 2026

Uh oh!

nadahalli Mar 16, 2026

Uh oh!

nadahalli Mar 16, 2026

Uh oh!

nadahalli Mar 16, 2026

Uh oh!

vreff Mar 16, 2026

Uh oh!

nadahalli Mar 16, 2026

Uh oh!

vreff Mar 16, 2026

Uh oh!

vreff commented Mar 16, 2026

Uh oh!

nadahalli commented Mar 16, 2026

Uh oh!

vreff commented Mar 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

nadahalli commented Mar 16, 2026

Summary

Uh oh!

github-actions bot commented Mar 16, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

nadahalli Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

nadahalli Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

nadahalli Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

nadahalli Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

vreff Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

nadahalli Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

vreff Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

vreff commented Mar 16, 2026

Uh oh!

nadahalli commented Mar 16, 2026

Uh oh!

vreff commented Mar 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants