-
Notifications
You must be signed in to change notification settings - Fork 25
ContractIdlJson in solana service logpoller filter type #1785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR renames the field EventIdlJSON to ContractIdlJSON across the Solana chain integration code to better reflect that the IDL (Interface Description Language) JSON describes the contract rather than just the event.
Changes:
- Renamed
EventIdlJSON/EventIdlJsontoContractIdlJSON/ContractIdlJsonin the Go types, protobuf definitions, and generated protobuf code - Updated test fixtures to use the new field name
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/types/chains/solana/lp_types.go | Renamed field from EventIdlJSON to ContractIdlJSON in the LPFilterQuery struct |
| pkg/chains/solana/solana.proto | Updated protobuf field name from event_idl_json to contract_idl_json |
| pkg/chains/solana/solana.pb.go | Regenerated protobuf code reflecting the field rename and accessor method updates |
| pkg/chains/solana/proto_helpers_test.go | Updated test fixture to use ContractIdlJson instead of EventIdlJson |
| pkg/chains/solana/proto_helpers.go | Updated conversion functions to map between the renamed protobuf and Go type fields |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
👋 yashnevatia, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
|
ilija42
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you just link the followup PRs because this is a breaking change
jmank88
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMHO we should just deprecate the field instead of making a breaking change. However, in lieu of that, we at least need to have the full set of follow-up PRs ready to merge before merging this one.
smartcontractkit/chainlink-solana#1425
Will consume the breaking change