Skip to content

Conversation

@yashnevatia
Copy link
Contributor

@yashnevatia yashnevatia commented Jan 21, 2026

smartcontractkit/chainlink-solana#1425
Will consume the breaking change

@yashnevatia yashnevatia requested a review from a team as a code owner January 21, 2026 13:35
Copilot AI review requested due to automatic review settings January 21, 2026 13:35
@yashnevatia yashnevatia changed the title ContractIdlJson ContractIdlJson in solana service logpoller filter type Jan 21, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR renames the field EventIdlJSON to ContractIdlJSON across the Solana chain integration code to better reflect that the IDL (Interface Description Language) JSON describes the contract rather than just the event.

Changes:

  • Renamed EventIdlJSON/EventIdlJson to ContractIdlJSON/ContractIdlJson in the Go types, protobuf definitions, and generated protobuf code
  • Updated test fixtures to use the new field name

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pkg/types/chains/solana/lp_types.go Renamed field from EventIdlJSON to ContractIdlJSON in the LPFilterQuery struct
pkg/chains/solana/solana.proto Updated protobuf field name from event_idl_json to contract_idl_json
pkg/chains/solana/solana.pb.go Regenerated protobuf code reflecting the field rename and accessor method updates
pkg/chains/solana/proto_helpers_test.go Updated test fixture to use ContractIdlJson instead of EventIdlJson
pkg/chains/solana/proto_helpers.go Updated conversion functions to map between the renamed protobuf and Go type fields

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

👋 yashnevatia, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions
Copy link

⚠️ API Diff Results - Breaking changes detected

📦 Module: github-com-smartcontractkit-chainlink-common

🔴 Breaking Changes (3)

pkg/chains/solana.(*LPFilterQuery) (1)
  • GetEventIdlJson — 🗑️ Removed
pkg/chains/solana.LPFilterQuery (1)
  • EventIdlJson — 🗑️ Removed
pkg/types/chains/solana.LPFilterQuery (1)
  • EventIdlJSON — 🗑️ Removed

📄 View full apidiff report

Copy link
Contributor

@ilija42 ilija42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just link the followup PRs because this is a breaking change

Copy link
Contributor

@jmank88 jmank88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO we should just deprecate the field instead of making a breaking change. However, in lieu of that, we at least need to have the full set of follow-up PRs ready to merge before merging this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants