-
Notifications
You must be signed in to change notification settings - Fork 25
feat(ci): apidiff-go v2 #1734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(ci): apidiff-go v2 #1734
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR upgrades the API diff workflow to v2, enabling dynamic analysis of all changed Go modules rather than just the root module. The workflow now uses changed-modules-go/v1 to detect which modules have changes and runs apidiff-go/v2 against each one separately, with improved formatting and support for compatible changes in PR comments.
Key changes:
- Added a new
changed-modulesjob to dynamically detect modules with changes using file patterns for Go files and modules - Converted the single
root-modulejob into a matrix-basedanalyze-api-changesjob that runs per changed module - Updated actions to newer versions (checkout@v5, apidiff-go/v2) with adjusted configuration
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Changes
changed-modules-go/v1andapidiff-go/v2Notes
This is a step towards being able to recommend versions for these modules.
Also v2 addresses 3 formatting problems:
New Behaviour
Example
DX-2304, DX-2305, DX-2308