build/devenv: introduce configuration profiles#1145
Open
winder wants to merge 4 commits into
Open
Conversation
This was referenced Jun 1, 2026
708d4e2 to
df70003
Compare
1f84674 to
2d25bcd
Compare
4 tasks
df70003 to
e0ccd63
Compare
Adds *.profile files as a first-class way to describe a complete environment configuration — mode, ordered config files, and optional output path — so users no longer need tribal knowledge to construct a valid `ccv up` invocation. CLI changes: - `up` and `restart` gain --profile/-p and --output/-o flags - Positional *.profile args are treated as --profile (shell-completion friendly) - No args defaults to standard.profile instead of bare env.toml - --profile is mutually exclusive with --env-mode, --output, and positional TOML args (validated at run time) - `ccv shell` accepts --profile/-p and primes the active config so bare `up`/`restart` inside the shell reuses the same profile Shell completion (completion.go) now dynamically scans *.profile files in the working directory instead of the hardcoded TOML combo list. config.go gains CTF_OUTPUT env var; Store() checks it before deriving the output path from CTF_CONFIGS, enabling --output and profile output overrides to flow through without changing every call site. Six built-in profiles in build/devenv/: standard.profile legacy + env.toml phased.profile phased + env-phased.toml standard.clnode.profile legacy + env.toml,env-cl.toml standard.clnode.ci.profile legacy + env.toml,env-cl.toml,env-cl-ci.toml phased.clnode.profile phased + env-phased.toml,env-cl-phased.toml phased.clnode.ci.profile phased + env-phased.toml,env-cl-phased.toml,env-cl-ci-phased.toml
Replaces raw config combos and --env-mode flags in test-smoke.yaml and test-cl-smoke.yaml with --profile, and passes --output env-out.toml so every run writes a consistent output path the tests can find without SMOKE_TEST_CONFIG overrides. Adds four profiles for CI-specific config combos that had no existing profile: standard.one-exec-per-chain, standard.src-auto-mine, standard.ha.clnode.ci, and standard.clnode.ci.one-exec-per-chain.
Adds `ccv run --profile <name> --test <pattern>` to drive the full integration-test lifecycle (image build, environment startup, go test) in a single command, writing output to a run-scoped file so parallel runs do not collide.
Documents the profile system, ccv run command, and breaking changes to ccv up defaults introduced in this branch. Adds before/after examples for the --env-mode removal and the new --profile / --output flags.
2d25bcd to
a81195f
Compare
|
Code coverage report:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Chain
There are multiple open pull requests that feed into each other:
Description
Adds *.profile files as a first-class way to describe a complete environment configuration — mode, ordered config files, and optional output path — so users no longer need tribal knowledge to construct a valid
ccv upinvocation.CLI changes:
upandrestartgain --profile/-p and --output/-o flagsccv shellaccepts --profile/-p and primes the active config so bareup/restartinside the shell reuses the same profileShell completion (completion.go) now dynamically scans *.profile files in the working directory instead of the hardcoded TOML combo list.
config.go gains CTF_OUTPUT env var; Store() checks it before deriving the output path from CTF_CONFIGS, enabling --output and profile output overrides to flow through without changing every call site.
Six built-in profiles in build/devenv/:
Testing
Checklist
changelogdirectory)just lint fix- no new lint errorsjust generate- mocks and protobufs are up to date