Add builtin interface, convert blockchain to builtin.#1101
Open
winder wants to merge 1 commit into
Open
Conversation
|
Code coverage report:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Introduces a “builtin” component stage to the build/devenv/runtime orchestrator to support a fixed, dependency-respecting startup order for foundational infrastructure, and migrates the blockchains component into that builtin stage.
Changes:
- Add
BuiltinComponentinterface and a pre-phase builtin execution loop with a fixedbuiltinOrder. - Improve overwrite-collision error messaging to distinguish builtins vs phases.
- Convert the
blockchainscomponent from Phase 1 toRunBuiltin, and add unit tests + mockery support.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| build/devenv/runtime/environment.go | Adds builtin ordering/execution before phases and enhances collision error messages to label “builtin” vs “phase N”. |
| build/devenv/runtime/environment_test.go | Adds unit tests covering builtin ordering, visibility of outputs, and sanity checks. |
| build/devenv/runtime/component.go | Introduces the BuiltinComponent interface. |
| build/devenv/internal/mocks/mock_BuiltinComponent.go | Adds generated mock for BuiltinComponent. |
| build/devenv/components/blockchains/component.go | Migrates blockchain provisioning from RunPhase1 to RunBuiltin. |
| build/devenv/.mockery.yaml | Registers BuiltinComponent for mock generation. |
Files not reviewed (1)
- build/devenv/internal/mocks/mock_BuiltinComponent.go: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add ordered builtin component logic to the devenv. Turn blockchain component into a builtin.
Testing
New unit test. Existing phased devenv integ test for regression testing.
Checklist
changelogdirectory)just lint fix- no new lint errorsjust generate- mocks and protobufs are up to date