[Chore] refactor devenv (transmitter) key funding#1096
Draft
faisal-chainlink wants to merge 4 commits into
Draft
[Chore] refactor devenv (transmitter) key funding#1096faisal-chainlink wants to merge 4 commits into
faisal-chainlink wants to merge 4 commits into
Conversation
|
Code coverage report:
|
| // for this chain family. It should look up its DefaultTransmitterKeyName | ||
| // in keys.Keys and convert the public key to the appropriate address format. | ||
| // Returns nil if the key is not found. | ||
| DeriveAddressesFromKeys(keys services.BootstrapKeys) []protocol.UnknownAddress |
Contributor
Author
There was a problem hiding this comment.
perhaps it's better to place this within the ChainFamilyAdapter rather than here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This issue this PR solves is that devenv previously ignored non-EVM keys when bringing up a bootstrapped service. The
#FetchBootstrapKeysmethod tries to handle conversion of public keys to addresses which works well for EVM but would require hardcoding some keys names inchainlink-ccvif we want to apply the same approach for altVMs (specifically ones that use a different address format than than of EVM).The changes are primarily concerned without allowing each impl factory to return the name of the default key (name) used for transmission as well as exposing a method for deducing the address from a
keystorekey response.Finally, the EVM factory and other EVM impls are updated to handle the change described above.
Testing
chainlink-stellaruses the changes defined in this PRChecklist
...TODO
changelogdirectory)just lint fix- no new lint errorsjust generate- mocks and protobufs are up to date