tcapi: simplified interface#1092
Draft
makramkd wants to merge 1 commit into
Draft
Conversation
* Run/HavePrerequisites only take context * Decouple ccv.Cfg from tcapi interface
|
Code coverage report:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
tcapi.TestCaseinterface's methods were depending onccv.CfgandTestHarness, both of which make it difficult to run test cases on non-ephemeral environments like CLD environments.This is the first step in making the test cases environment-agnostic:
tcapi.TestCasemethods now only take acontext.Context, typically the test context.deployment.Environmentand functional options that specify things like aggregator and indexer clients. This is because in CLD such clients are constructed from URLs that are retrieved from outside the datastore, compared to the URLs being in theccv.Cfgin ephemeral envs.basictest cases now make the aggregator and indexer guards optional; i.e. if aggregator and indexer clients are made available via the requisite functional options, the guards are enabled, else they are disabled. This kind of behaviour should probably be applied to all futureTestCaseimplementations.The next steps will be:
Testing
Checklist
changelogdirectory)just lint fix- no new lint errorsjust generate- mocks and protobufs are up to date