Fix flakes#1043
Open
RensR wants to merge 1 commit into
Open
Conversation
|
Code coverage report:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses test flakiness in the SourceReader service tests by replacing fixed sleeps with polling-based assertions, making the tests more robust across -race, -short, and slower CI environments.
Changes:
- Replaced a hard-coded
time.Sleep(300ms)withrequire.Eventuallyin two event-monitoring-loop panic recovery tests. - Simplified assertions by relying on the polling condition to enforce the minimum number of loop iterations observed.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
asoliman92
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace arbitrary 300ms sleep with polling.