Conversation
added 23 commits
April 6, 2022 16:19
decokeano
changed the title
brunohsouza
requested changes
May 13, 2022
Dockerfile
Outdated
| FROM composer:2 AS composer | ||
|
|
||
| FROM php:7.0-fpm | ||
| FROM php:8.1.0-fpm |
There was a problem hiding this comment.
As we are defining the minimum version to PHP 8.0. I'd change it to 8.0-fpm.
Dockerfile
Outdated
| FROM composer:2 AS composer | ||
|
|
||
| FROM php:7.0-fpm | ||
| FROM php:8.1.0-fpm |
composer.json
Outdated
| ], | ||
| "require": { | ||
| "php": ">=5.4.0", | ||
| "php": ">=7.0 || >=8.0", |
There was a problem hiding this comment.
If you defined it as 7.0, then we cannot use nullable return types. I saw some commits using it.
| * @return string | ||
| */ | ||
| public function __doRequest($request, $location, $action, $version, $oneWay = 0) | ||
| public function __doRequest($request, $location, $action, $version, $oneWay = 0): ?string |
There was a problem hiding this comment.
Nullable return types will not working on PHP 7.0.
| } | ||
|
|
||
| public function doSetUp() | ||
| public function setUp(): void |
There was a problem hiding this comment.
void is not an acceptable return type on PHP 7.0
| use \Symfony\Bridge\PhpUnit\SetUpTearDownTrait; | ||
|
|
||
| protected function doSetUp() | ||
| protected function setUp(): void |
There was a problem hiding this comment.
void is not an acceptable return type on PHP 7.0
| use \Symfony\Bridge\PhpUnit\SetUpTearDownTrait; | ||
|
|
||
| protected function doSetUp() | ||
| protected function setUp(): void |
There was a problem hiding this comment.
void is not an acceptable return type on PHP 7.0.
added 10 commits
May 13, 2022 12:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.