-
-
Notifications
You must be signed in to change notification settings - Fork 58
V1.5.5 #697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
flarco
wants to merge
23
commits into
main
Choose a base branch
from
v1.5.5
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in replication tests
- refactor `AddPrimaryKeyToDDL` to accurately locate the closing parenthesis of column definitions, ensuring `PRIMARY KEY` is inserted before any table options like `WITH` clauses (fixes #694) - previously, the primary key could be incorrectly appended inside the `WITH` clause, resulting in invalid SQL DDL test(replication): add test for custom table_ddl with primary key and with clause - introduce `r.88.table_ddl_with_clause.yaml` to validate the fix for GitHub Issue #694 in an end-to-end replication scenario - verify that the target table is created with the specified primary key and table options (e.g., `DATA_COMPRESSION`) - add comprehensive unit tests for `AddPrimaryKeyToDDL` covering DDLs with and without `WITH` clauses, nested parentheses, and different dialects
- introduce `definition-only` mode for creating table and file definitions without data - support `definition-only` mode for database targets (e.g., postgres to mssql) - support `definition-only` mode for file targets (e.g., postgres to parquet/arrow) - inject `WHERE 1=0` into source queries to prevent data transfer - skip empty buffer check for file writes in `definition-only` mode - add validation for file targets, restricting to parquet and arrow formats - add cli tests for database and file targets - add cli test for `definition-only` failure with csv file target
…ust caching logic
- introduce `db2` type in `dbio` for specific DB2 handling - add `db2.yaml` template with core SQL operations and metadata queries - implement `GetType` method in `connection` to return more accurate type for ODBC connections - update `connection_local` to use `GetType` for better connection descriptions - modify `database` package to use `Template().Quote` for consistent quoting - enhance `GenerateDDL` to support `partition by`, `cluster by`, `distkey`, `sortkey`, and `primary key` clauses - update `GenerateMergeConfig` to include `src_insert_fields`, `tgt_fields`, and `placeholder_fields` for merge statements - adjust `GetOptimizeTableStatements` for column type optimization using `Template().Quote` - update `CompareChecksums` to use `Template().Quote` for field quoting - modify `AddMissingColumns` to use `Template().Quote` for column quoting - update `dbio_types` to support `column_upper` variable from templates for case normalization - add `TestSuiteDatabaseDB2` to run tests for DB2 database - update `go.mod` and `go.sum` for `godbc` dependency
…function parameter
… prevent process hang
…enhance MySQL/MariaDB connection for local infile support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.