Extend RouteCollectorProxy::redirect() to serve non-GET requests too#3430
Open
uhle wants to merge 1 commit intoslimphp:4.xfrom
Open
Extend RouteCollectorProxy::redirect() to serve non-GET requests too#3430uhle wants to merge 1 commit intoslimphp:4.xfrom
uhle wants to merge 1 commit intoslimphp:4.xfrom
Conversation
|
This feels correct 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While
RouteCollectorProxy::redirect()is quite handy and useful, it only works for GET requests. Therefore I propose to extend it by another argument to set the accepted HTTP methods. Its default value should be['GET']so that legacy code can run unchanged. Then it would be possible to also use it like that: