migrate to v52.11.0 #14
Conversation
✅ Deploy Preview for agitated-cori-79a573 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR migrates the documentation version from 52.10.1 to 52.11.0 and adds conditional logic to disable the llmstxt plugin for non-English documentation sites.
- Updated version to 52.11.0 in package.json
- Added conditional rendering for the llmstxt plugin based on locale configuration
- Imported the VitePress config to check if the root locale is English
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Bumped version from 52.10.1 to 52.11.0 |
| vite.config.ts | Added conditional logic to enable llmstxt plugin only for English documentation by checking the root locale label |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| import llmstxt from 'vitepress-plugin-llms' | ||
| import config from './.vitepress/config' | ||
|
|
||
| const IS_ROOT_ENGLISH_DOC = config.locales?.root.label.includes('English') || false |
There was a problem hiding this comment.
The variable name IS_ROOT_ENGLISH_DOC is potentially confusing. Based on the config, the root locale is Japanese ("日本語"), not English. This check determines if the root locale's label includes "English", which will be false for this Japanese documentation site. Consider renaming to SHOULD_ENABLE_LLMSTXT or IS_ENGLISH_LOCALE for better clarity about its purpose.
|
https://sli.dev に v52.11.0 がデプロイされるまでマージ待機 (先行してしまうため) |
2 participants
resolve #10