Skip to content

refactor(experiment): swap prompt interrupt error after prompt interrupt#412

Merged
zimeg merged 2 commits intomainfrom
zimeg-refactor-huh-interrupt
Mar 18, 2026
Merged

refactor(experiment): swap prompt interrupt error after prompt interrupt#412
zimeg merged 2 commits intomainfrom
zimeg-refactor-huh-interrupt

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented Mar 18, 2026

Changelog

N/A! 🧪 ✨

Summary

This PR follows #348 to swap prompt interrupt errors after the prompt is interrupted instead of replacing the huh error itself 👻

Reviewers

We can confirm changes work as expected with:

$ slack create -e charm # Interrupt please!
...
$ echo $?
130
$ slack create -e charm > oopsieserror.out
...
$ echo $?
1

Observe no prompt_error is surfaced for interrupts! These continue to be quiet!

Notes

No change to functionalities or noticed outputs but this might give us confidence that updates to prompts don't cause unexpected happenings due to internal handling of the huh error values! 🐞

Requirements

@zimeg zimeg added this to the Next Release milestone Mar 18, 2026
@zimeg zimeg self-assigned this Mar 18, 2026
@zimeg zimeg requested a review from a team as a code owner March 18, 2026 07:37
@zimeg zimeg added code health M-T: Test improvements and anything that improves code health experiment Experimental feature accessed behind the --experiment flag or toggle semver:patch Use on pull requests to describe the release version increment labels Mar 18, 2026
@codecov
Copy link

codecov bot commented Mar 18, 2026

Codecov Report

❌ Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.17%. Comparing base (8056444) to head (df4de83).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/iostreams/charm.go 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #412      +/-   ##
==========================================
- Coverage   68.24%   68.17%   -0.08%     
==========================================
  Files         218      218              
  Lines       18049    18058       +9     
==========================================
- Hits        12318    12311       -7     
- Misses       4578     4593      +15     
- Partials     1153     1154       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Easy read and looks good to me! Thanks for the small, focused PR and clear test steps on this one!

🧪 Local testing works well on my side.

Comment on lines +4 to +6
"Bash(go build:*)",
"Bash(go mod tidy:*)",
"Bash(go test:*)",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔋 ⚡

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mwbrooks @claude Kept asking me to build particular packages. I keep saying "yes" of course but now I hope it's known 🪬

@zimeg
Copy link
Member Author

zimeg commented Mar 18, 2026

@mwbrooks Super duper appreciate the quick review too! 🌻

Let's merge this with confidence that packages are more contained and experiments perhaps evermore stable 💝 🍀

@zimeg zimeg merged commit 34ac465 into main Mar 18, 2026
8 checks passed
@zimeg zimeg deleted the zimeg-refactor-huh-interrupt branch March 18, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code health M-T: Test improvements and anything that improves code health experiment Experimental feature accessed behind the --experiment flag or toggle semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants