refactor(experiment): swap prompt interrupt error after prompt interrupt#412
Merged
refactor(experiment): swap prompt interrupt error after prompt interrupt#412
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #412 +/- ##
==========================================
- Coverage 68.24% 68.17% -0.08%
==========================================
Files 218 218
Lines 18049 18058 +9
==========================================
- Hits 12318 12311 -7
- Misses 4578 4593 +15
- Partials 1153 1154 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mwbrooks
approved these changes
Mar 18, 2026
Member
mwbrooks
left a comment
There was a problem hiding this comment.
✅ Easy read and looks good to me! Thanks for the small, focused PR and clear test steps on this one!
🧪 Local testing works well on my side.
Comment on lines
+4
to
+6
| "Bash(go build:*)", | ||
| "Bash(go mod tidy:*)", | ||
| "Bash(go test:*)", |
Member
Author
Member
Author
|
@mwbrooks Super duper appreciate the quick review too! 🌻 Let's merge this with confidence that packages are more contained and experiments perhaps evermore stable 💝 🍀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Summary
This PR follows #348 to swap prompt interrupt errors after the prompt is interrupted instead of replacing the
huherror itself 👻Reviewers
We can confirm changes work as expected with:
Observe no
prompt_erroris surfaced for interrupts! These continue to be quiet!Notes
No change to functionalities or noticed outputs but this might give us confidence that updates to prompts don't cause unexpected happenings due to internal handling of the
huherror values! 🐞Requirements