Skip to content

refactor(experiment): separate huh and lipgloss changes of charm#411

Open
zimeg wants to merge 1 commit intomainfrom
zimeg-experiment-charm-huh-lipgloss
Open

refactor(experiment): separate huh and lipgloss changes of charm#411
zimeg wants to merge 1 commit intomainfrom
zimeg-experiment-charm-huh-lipgloss

Conversation

@zimeg
Copy link
Member

@zimeg zimeg commented Mar 18, 2026

Changelog

N/A - Though changes to the experiments page are included! 🧪 ✨

Summary

This PR separates the huh and lipgloss changes of charm experiment into separate experiments to keep changes of prompts and style ordered toward stable release 🎁

Preview

Before changes:

$ slack create -e charm

After changes:

$ slack create -e huh -e lipgloss

Requirements

@zimeg zimeg added this to the Next Release milestone Mar 18, 2026
@zimeg zimeg self-assigned this Mar 18, 2026
@zimeg zimeg added the code health M-T: Test improvements and anything that improves code health label Mar 18, 2026
@zimeg zimeg requested review from a team as code owners March 18, 2026 07:16
@zimeg zimeg added experiment Experimental feature accessed behind the --experiment flag or toggle semver:patch Use on pull requests to describe the release version increment labels Mar 18, 2026
@codecov
Copy link

codecov bot commented Mar 18, 2026

Codecov Report

❌ Patch coverage is 58.20896% with 28 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.23%. Comparing base (8056444) to head (48b912d).

Files with missing lines Patch % Lines
internal/iostreams/charm.go 60.00% 10 Missing ⚠️
internal/style/template.go 0.00% 7 Missing and 1 partial ⚠️
internal/iostreams/prompts.go 0.00% 5 Missing ⚠️
internal/style/style.go 90.90% 2 Missing ⚠️
cmd/help/help.go 50.00% 0 Missing and 1 partial ⚠️
cmd/project/create_samples.go 50.00% 1 Missing ⚠️
internal/iostreams/printer.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #411      +/-   ##
==========================================
- Coverage   68.24%   68.23%   -0.02%     
==========================================
  Files         218      218              
  Lines       18049    18054       +5     
==========================================
+ Hits        12318    12319       +1     
- Misses       4578     4581       +3     
- Partials     1153     1154       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Thank you so much for breaking these out! Confidence toward a huh release is feeling higher, scope is smaller, and focus is stronger 💪🏻 I imagine this was a tedious task, but I appreciate it! 🙇🏻

❓ Left a non-blocking question - just something to think about but not take action on right now.


Below is a list of updates related to experiments.

- **March 2026**: Split the `charm` experiment into more beautiful `huh` prompts and prettier `lipgloss` styles for ongoing change.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏻

@@ -14,19 +14,29 @@

package iostreams
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Long-term, is there a more appropriate filename than charm.go? As a new maintainer I may not connect that two packages - huh and lipgloss - are from the same group charm. I see the newForm constructor uses both, but I wonder if we have an opportunity for a huh.go instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mwbrooks I share this feeling. The terms "charm" or "huh" or "lipgloss" are meaningful for package imports but we might want to refactor this into a different packages once experiments conclude:

  • internal/iostreams/charm.go -> internal/iostreams/forms.go

I'm not against huh.go either but it takes me a second to realize it's asking for input the same 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code health M-T: Test improvements and anything that improves code health experiment Experimental feature accessed behind the --experiment flag or toggle semver:patch Use on pull requests to describe the release version increment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants