fix: unquote environment variable passed to hook commands

[zimeg]

Changelog

Environment variable values set for hook commands are no longer surrounded with double quotes.

Summary

This PR fixes an issue where environment variables were set with double quotes surrounding values:

slack-cli/internal/goutils/map.go

Lines 23 to 39 in 8056444

	// MapToStringSlice converts a map[string]string to a slice of strings with
	// elements key="value" from the map with an optional prefix
	func MapToStringSlice(args map[string]string, prefix string) []string {
	var res = []string{}
	for name, value := range args {
	if len(value) > 0 {
	var escapedValue string
	if runtime.GOOS == "windows" {
	escapedValue = strings.ReplaceAll(value, `"`, "`\"")
	} else {
	escapedValue = strings.ReplaceAll(value, `"`, `\"`)
	}
	res = append(res, fmt.Sprintf(`%s%s="%s"`, prefix, name, escapedValue))
	}
	}
	return res
	}

	// Env specifies the environment of the process.
	// Each entry is of the form "key=value".

📚 Reference: https://pkg.go.dev/os/exec#Cmd

Requirements

• I've read and understood the Contributing Guidelines and have done my best effort to follow them.
• I've read and agree to the Code of Conduct.

[codecov]

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.21%. Comparing base (8056444) to head (5b2cf70).

Files with missing lines	Patch %	Lines
internal/pkg/platform/localserver.go	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #410      +/-   ##
==========================================
- Coverage   68.24%   68.21%   -0.03%     
==========================================
  Files         218      218              
  Lines       18049    18051       +2     
==========================================
- Hits        12318    12314       -4     
- Misses       4578     4585       +7     
+ Partials     1153     1152       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[zimeg]

💌 Notes on code for the amazing reviewers! I am also planning to follow up with testing notes before asking for particular review 🧪 ✨

[zimeg]

🔭 note: These values are set for both the default and message-boundaries protocols:

slack-cli/internal/hooks/hook_executor_default.go

Line 70 in 8056444

cmd := opts.Exec.Command(cmdEnvVars, stdout, stderr, opts.Stdin, cmdArgs[0], cmdArgVars...)

slack-cli/internal/hooks/hook_executor_v2.go

Line 87 in 8056444

cmd := opts.Exec.Command(cmdEnvVars, &stdout, stderr, opts.Stdin, cmdArgs[0], cmdArgVars...)

slack-cli/internal/hooks/shell.go

Lines 56 to 59 in 8056444

	// Command creates a command ready to be run with the current processes shell
	func (sh ShellExec) Command(env []string, stdout io.Writer, stderr io.Writer, stdin io.Reader, name string, arg ...string) ShellCommand {
	cmd := sh.command(name, arg...)
	cmd.Env = env

[zimeg]

🏁 note: I understand the MapToStringSlice utilities to be useful in escaping command line arguments but we might not need this with the direct environment variable value setting in commands.

🏆 ramble: This implementation in localserver is the other find of a direct call to the hooks command executor so shares the change!