-
Notifications
You must be signed in to change notification settings - Fork 31
feat(experiment): create and delete developer sandboxes #389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
c0b11c5
eabc9ba
cea2bcd
b1699bb
a35fbc3
a50fb40
0b525a5
2e50c5b
ca46e13
43e9bac
9851ac7
bf34f27
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,266 @@ | ||
| // Copyright 2022-2026 Salesforce, Inc. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package sandbox | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "strconv" | ||
| "strings" | ||
| "time" | ||
| "unicode" | ||
|
|
||
| "github.com/slackapi/slack-cli/internal/shared" | ||
| "github.com/slackapi/slack-cli/internal/slackerror" | ||
| "github.com/slackapi/slack-cli/internal/style" | ||
| "github.com/spf13/cobra" | ||
| ) | ||
|
|
||
| type createFlags struct { | ||
| name string | ||
| domain string | ||
| password string | ||
| locale string | ||
| owningOrgID string | ||
| template string | ||
| eventCode string | ||
| archiveTTL string // TTL duration, e.g. 1d, 2w, 3mo | ||
| archiveDate string // explicit date yyyy-mm-dd | ||
| partner bool | ||
| } | ||
|
|
||
| var createCmdFlags createFlags | ||
|
|
||
| // templateNameToID maps user-friendly template names to integer IDs | ||
| var templateNameToID = map[string]int{ | ||
| "default": 1, // The default template | ||
| "empty": 0, // The sandbox will be empty if the template param is not set | ||
| } | ||
|
|
||
| // getTemplateID converts a template string to an integer ID | ||
| func getTemplateID(template string) (int, error) { | ||
| if template == "" { | ||
| return 0, nil | ||
| } | ||
| key := strings.ToLower(strings.TrimSpace(template)) | ||
| // If the provided string is present in the map, return the ID | ||
| if id, ok := templateNameToID[key]; ok { | ||
| return id, nil | ||
| } | ||
| // We also accept an integer passed directly via the flag | ||
| if id, err := strconv.Atoi(key); err == nil { | ||
| return id, nil | ||
| } | ||
| return 0, slackerror.New(slackerror.ErrInvalidTemplateID). | ||
| WithMessage("Invalid template: %q", template) | ||
| } | ||
|
|
||
| func NewCreateCommand(clients *shared.ClientFactory) *cobra.Command { | ||
| cmd := &cobra.Command{ | ||
| Use: "create [flags]", | ||
| Short: "Create a developer sandbox", | ||
| Long: `Create a new Slack developer sandbox`, | ||
| Example: style.ExampleCommandsf([]style.ExampleCommand{ | ||
| {Command: "sandbox create --name test-box --password mypass", Meaning: "Create a sandbox named test-box"}, | ||
| {Command: "sandbox create --name test-box --password mypass --domain test-box --archive-ttl 1d", Meaning: "Create a temporary sandbox that will be archived in 1 day"}, | ||
| {Command: "sandbox create --name test-box --password mypass --domain test-box --archive-date 2025-12-31", Meaning: "Create a sandbox that will be archived on a specific date"}, | ||
vegeris marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| }), | ||
| Args: cobra.NoArgs, | ||
| PreRunE: func(cmd *cobra.Command, args []string) error { | ||
| return requireSandboxExperiment(clients) | ||
| }, | ||
| RunE: func(cmd *cobra.Command, args []string) error { | ||
| return runCreateCommand(cmd, clients) | ||
| }, | ||
| } | ||
|
|
||
| cmd.Flags().StringVar(&createCmdFlags.name, "name", "", "Organization name for the new sandbox") | ||
| cmd.Flags().StringVar(&createCmdFlags.domain, "domain", "", "Team domain. If not provided, will be derived from org name") | ||
| cmd.Flags().StringVar(&createCmdFlags.password, "password", "", "Password used to log into the sandbox") | ||
| cmd.Flags().StringVar(&createCmdFlags.locale, "locale", "", "Locale (eg. en-us, languageCode-countryCode)") | ||
| cmd.Flags().StringVar(&createCmdFlags.template, "template", "", "Template for pre-defined data to preload (default, empty)") | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I updated the handling of the |
||
| cmd.Flags().StringVar(&createCmdFlags.eventCode, "event-code", "", "Event code for the sandbox") | ||
| cmd.Flags().StringVar(&createCmdFlags.archiveTTL, "archive-ttl", "", "Time-to-live duration; sandbox will be archived at end of day after this period (eg. 1d, 3w, 2mo). Cannot be used with --archive-date") | ||
| cmd.Flags().StringVar(&createCmdFlags.archiveDate, "archive-date", "", "Explicit archive date in yyyy-mm-dd format. Cannot be used with --archive-ttl") | ||
| cmd.Flags().BoolVar(&createCmdFlags.partner, "partner", false, "Developers who are part of the Partner program can create partner sandboxes") | ||
|
|
||
| // If one's developer account is managed by multiple Production Slack teams, one of those team IDs must be provided in the command | ||
| cmd.Flags().StringVar(&createCmdFlags.owningOrgID, "owning-org-id", "", "Enterprise team ID that manages your developer account, if applicable") | ||
|
|
||
| if err := cmd.MarkFlagRequired("name"); err != nil { | ||
| panic(err) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. question: Have we checked what happens when we throw a I don't think we've used the
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| } | ||
| if err := cmd.MarkFlagRequired("password"); err != nil { | ||
| panic(err) | ||
| } | ||
|
Comment on lines
+101
to
+106
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🏁 issue(non-blocking): We might want prompt alternatives for required flags but no blocker for this PR! |
||
|
|
||
| return cmd | ||
| } | ||
|
|
||
| func runCreateCommand(cmd *cobra.Command, clients *shared.ClientFactory) error { | ||
| ctx := cmd.Context() | ||
|
|
||
| auth, err := getSandboxAuth(ctx, clients) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| domain := createCmdFlags.domain | ||
| if domain == "" { | ||
| var err error | ||
| domain, err = domainFromName(createCmdFlags.name) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| } | ||
|
|
||
| if createCmdFlags.archiveTTL != "" && createCmdFlags.archiveDate != "" { | ||
| return slackerror.New(slackerror.ErrInvalidArguments). | ||
| WithMessage("Cannot use both --archive-ttl and --archive-date") | ||
| } | ||
|
|
||
| archiveEpochDatetime := int64(0) | ||
| if createCmdFlags.archiveTTL != "" { | ||
| archiveEpochDatetime, err = getEpochFromTTL(createCmdFlags.archiveTTL) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| } else if createCmdFlags.archiveDate != "" { | ||
| archiveEpochDatetime, err = getEpochFromDate(createCmdFlags.archiveDate) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| } | ||
|
|
||
| templateID, err := getTemplateID(createCmdFlags.template) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| teamID, sandboxURL, err := clients.API().CreateSandbox(ctx, auth.Token, | ||
| createCmdFlags.name, | ||
| domain, | ||
| createCmdFlags.password, | ||
| createCmdFlags.locale, | ||
| createCmdFlags.owningOrgID, | ||
| templateID, | ||
| createCmdFlags.eventCode, | ||
| archiveEpochDatetime, | ||
| createCmdFlags.partner, | ||
| ) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| printCreateSuccess(cmd, clients, teamID, sandboxURL) | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| // getEpochFromTTL parses a time-to-live string (e.g., "1d", "2w", "3mo") and returns the Unix epoch | ||
| // when the sandbox will be archived. Supports days (d), weeks (w), and months (mo). | ||
| // Minimum is 1 day, maximum is 6 months. | ||
| func getEpochFromTTL(ttl string) (int64, error) { | ||
| lower := strings.TrimSpace(strings.ToLower(ttl)) | ||
| if lower == "" { | ||
| return 0, slackerror.New(slackerror.ErrInvalidArchiveTTL) | ||
| } | ||
|
|
||
| var target time.Time | ||
| now := time.Now() | ||
|
|
||
| switch { | ||
| case strings.HasSuffix(lower, "d"): | ||
| n, err := strconv.Atoi(strings.TrimSuffix(lower, "d")) | ||
| if err != nil || n < 1 { | ||
| return 0, slackerror.New(slackerror.ErrInvalidArchiveTTL) | ||
| } | ||
| target = now.AddDate(0, 0, n) | ||
| case strings.HasSuffix(lower, "w"): | ||
| n, err := strconv.Atoi(strings.TrimSuffix(lower, "w")) | ||
| if err != nil || n < 1 { | ||
| return 0, slackerror.New(slackerror.ErrInvalidArchiveTTL) | ||
| } | ||
| target = now.AddDate(0, 0, n*7) | ||
| case strings.HasSuffix(lower, "mo"): | ||
| n, err := strconv.Atoi(strings.TrimSuffix(lower, "mo")) | ||
| if err != nil || n < 1 { | ||
| return 0, slackerror.New(slackerror.ErrInvalidArchiveTTL) | ||
| } | ||
| target = now.AddDate(0, n, 0) | ||
| default: | ||
| return 0, slackerror.New(slackerror.ErrInvalidArchiveTTL) | ||
| } | ||
|
|
||
| maxAllowed := now.AddDate(0, 6, 0) | ||
| minAllowed := now.AddDate(0, 0, 1) | ||
| if target.Before(minAllowed) { | ||
| return 0, slackerror.New(slackerror.ErrInvalidArchiveTTL) | ||
| } | ||
| if target.After(maxAllowed) { | ||
| return 0, slackerror.New(slackerror.ErrInvalidArchiveTTL) | ||
| } | ||
|
|
||
| return target.Unix(), nil | ||
| } | ||
|
|
||
| // getEpochFromDate parses a date in yyyy-mm-dd format and returns the Unix epoch at start of that day (UTC). | ||
| func getEpochFromDate(dateStr string) (int64, error) { | ||
| dateFormat := "2006-01-02" | ||
| t, err := time.ParseInLocation(dateFormat, dateStr, time.UTC) | ||
| if err != nil { | ||
| return 0, slackerror.New(slackerror.ErrInvalidArguments). | ||
| WithMessage("Invalid archive date: %q", dateStr). | ||
| WithRemediation("Use yyyy-mm-dd format") | ||
| } | ||
| now := time.Now().UTC() | ||
| today := time.Date(now.Year(), now.Month(), now.Day(), 0, 0, 0, 0, time.UTC) | ||
| if t.Before(today) { | ||
| return 0, slackerror.New(slackerror.ErrInvalidArguments). | ||
| WithMessage("Archive date must be in the future") | ||
| } | ||
| return t.Unix(), nil | ||
| } | ||
|
|
||
| // domainFromName derives domain-safe text from the name of the sandbox (lowercase, alphanumeric + hyphens). | ||
| func domainFromName(name string) (string, error) { | ||
| name = strings.ToLower(name) | ||
| name = strings.ReplaceAll(name, " ", "-") | ||
| name = strings.ReplaceAll(name, "_", "-") | ||
| var domain []byte | ||
| for _, r := range name { | ||
| if unicode.IsLetter(r) || unicode.IsDigit(r) || r == '-' { | ||
| domain = append(domain, byte(r)) | ||
| } | ||
| } | ||
| domain = []byte(strings.Trim(string(domain), "-")) | ||
| if len(domain) == 0 { | ||
| return "", slackerror.New(slackerror.ErrInvalidArguments). | ||
| WithMessage("Provide a valid domain name with the --domain flag") | ||
| } | ||
| return string(domain), nil | ||
| } | ||
|
|
||
| func printCreateSuccess(cmd *cobra.Command, clients *shared.ClientFactory, teamID, url string) { | ||
| ctx := cmd.Context() | ||
| clients.IO.PrintInfo(ctx, false, "\n%s", style.Sectionf(style.TextSection{ | ||
| Emoji: "beach_with_umbrella", | ||
| Text: "Sandbox Created", | ||
| Secondary: []string{ | ||
| fmt.Sprintf("Team ID: %s", teamID), | ||
| fmt.Sprintf("URL: %s", url), | ||
| }, | ||
| })) | ||
| clients.IO.PrintInfo(ctx, false, "Manage this sandbox from the CLI or visit\n%s", style.Secondary("https://api.slack.com/developer-program/sandboxes")) | ||
| } | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Preview:
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. praise: Excellent formatting choice! |
||

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Decided to include support for the
partnerflag, since we have validation on the backend to make sure only partner developers can create partner sandboxes