Draft
Conversation
Add and extend unit tests across the codebase to improve overall test coverage. New test files cover context getters/setters, recursive copy, image processing, archive utilities, API collaborators, and prompt permissions. Extended tests cover activity formatting, survey configs, error handling, style functions, version management, OS wrappers, HTTP client options, and datastore bulk operations.
- Fix format string in functionDeploymentToString producing "deployd" instead of "deployed" - Handle unchecked error return from cmd.Flags().Set() in flags_test.go - Update test expectation to match corrected deployment string
mwbrooks
added
code health
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #385 +/- ##
==========================================
+ Coverage 65.41% 69.78% +4.37%
==========================================
Files 214 214
Lines 17847 17847
==========================================
+ Hits 11674 12455 +781
+ Misses 5087 4234 -853
- Partials 1086 1158 +72 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Summary
This pull request attempts to increase our test coverage closer to 70% by focusing on files that do not require mocks or refactors to be tested.
internal/pkg/platform/activity.gowhere the deployment activity string produced "deployd" instead of "deployed" and caused a linter warning for the test-case.Requirements