feat: add task_card and plan blocks#1819
Conversation
zimeg
left a comment
There was a problem hiding this comment.
📣 Leaving a quick note of thoughts occurred in development!
slack_sdk/models/blocks/blocks.py
Outdated
|
|
||
| from slack_sdk.models import show_unknown_key_warning | ||
| from slack_sdk.models.basic_objects import JsonObject, JsonValidator | ||
| from slack_sdk.models.messages.chunk import URLSource |
There was a problem hiding this comment.
🤔 thought: This is introduced in #1806 but I'm not certain if it's best kept with the "messages" model or if it should be included as a block element?
There was a problem hiding this comment.
🗣️ note: In 6073ffe it's moved to the block elements - the url source can be used in standalone messages as well as in chunks.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat-ai-apps-thinking-steps #1819 +/- ##
==============================================================
Coverage ? 83.96%
==============================================================
Files ? 116
Lines ? 13212
Branches ? 0
==============================================================
Hits ? 11094
Misses ? 2118
Partials ? 0 ☔ View full report in Codecov by Sentry. |
mwbrooks
left a comment
There was a problem hiding this comment.
✅ Nice, thanks for adding the task_card and plan block.
🧪 Manually testing works well for both. Thanks for the example code!
|
@srtaalej @WilliamBergamin @mwbrooks Woo! I was getting caught up on merging base branches but once these tests are passing let's merge this! 🚢 💨 Some follow up remains for these blocks: |
Summary
This PR adds the
task_cardblock and theplanblock for usage in standalone messages.Testing
The following snippet shows a
task_cardblock:And this one shows a
planblock:Category
/docs(Documents)tests/integration_tests(Automated tests for this library)Requirements
python3 -m venv .venv && source .venv/bin/activate && ./scripts/run_validation.shafter making the changes.