Skip to content

chore: extract build script and expand socket-mode test coverage #2604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WilliamBergamin merged 2 commits into from
May 21, 2026
+22 −18
Merged

chore: extract build script and expand socket-mode test coverage #2604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61e6acc
chore: extract build script and expand socket-mode test coverage
WilliamBergamin May 20, 2026
c6c2dd4
chore: extract build script and expand socket-mode test coverage
WilliamBergamin May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 1 addition & 17 deletions .github/workflows/ci-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,23 +46,7 @@ jobs:
- name: Install dependencies
run: npm ci --verbose
- name: Build packages
run: |
# Build packages without internal dependencies
npm run build --workspace=@slack/cli-hooks
npm run build --workspace=@slack/cli-test

# Build base dependencies
npm run build --workspace=@slack/logger
npm run build --workspace=@slack/types

# Build packages requiring base dependencies
npm run build --workspace=@slack/web-api
npm run build --workspace=@slack/webhook

# Build packages that depend on the Web API
npm run build --workspace=@slack/oauth
npm run build --workspace=@slack/rtm-api
npm run build --workspace=@slack/socket-mode
run: npm run build
Copy link
Copy Markdown
Member

@zimeg zimeg May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪬suggestion: We might want to include this with release workflow too?

- name: Lint
run: npm run lint
- name: Build docs
Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
"packages/webhook"
],
"scripts": {
"build": "bash scripts/build.sh",
"changeset": "npx @changesets/cli",
"clean": "npm run build:clean --workspaces --if-present && git clean -xdf node_modules packages/**/node_modules && git clean -xf '**/package-lock.json'",
"docs": "npm run docs --workspaces --if-present",
Expand Down
2 changes: 1 addition & 1 deletion packages/socket-mode/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
"docs": "npx typedoc --plugin typedoc-plugin-markdown",
"prepack": "npm run build",
"test": "npm run test:unit && npm run test:integration",
"test:coverage": "npm run build && node --experimental-test-coverage --test-reporter=spec --test-reporter-destination=stdout --test-reporter=lcov --test-reporter-destination=lcov.info --test-reporter=junit --test-reporter-destination=test-results.xml --import tsx --test src/*.test.ts",
"test:coverage": "npm run build && node --experimental-test-coverage --test-reporter=spec --test-reporter-destination=stdout --test-reporter=lcov --test-reporter-destination=lcov.info --test-reporter=junit --test-reporter-destination=test-results.xml --import tsx --test src/*.test.ts test/integration.test.js",
Copy link
Copy Markdown
Member

@zimeg zimeg May 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧪 praise: Amazing catch to include in CI

"test:integration": "npm run build && node --import tsx --test test/integration.test.js",
"test:unit": "npm run build && bash -c 'node --test-reporter=spec --test-reporter-destination=stdout --test-reporter=junit --test-reporter-destination=test-results.xml --import tsx --test src/*.test.ts'",
"watch": "npx nodemon --watch 'src' --ext 'ts' --exec npm test"
Expand Down
19 changes: 19 additions & 0 deletions scripts/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
#!/usr/bin/env bash
set -e

# Build packages without internal dependencies
npm run build --workspace=packages/cli-hooks
npm run build --workspace=packages/cli-test

# Build base dependencies
npm run build --workspace=packages/logger
npm run build --workspace=packages/types

# Build packages requiring base dependencies
npm run build --workspace=packages/web-api
npm run build --workspace=packages/webhook

# Build packages that depend on the Web API
npm run build --workspace=packages/oauth
npm run build --workspace=packages/rtm-api
npm run build --workspace=packages/socket-mode
Loading