feat(web-api): add support for AbortSignal#2601
Open
LinusU wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: c5be203 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
WilliamBergamin
left a comment
WilliamBergamin
left a comment
There was a problem hiding this comment.
Thanks for your interest and contribution @LinusU 🙏
We plan to release version 8.0.0 of the web-api in the very near future 🚀 Since these changes are purely additive I'd prefer we include them in a minor release of the @slack/web-api package (example in 8.1.0)
The reasoning for this is simply to narrow the changes included in 8.0.0 and increase our odds of a smooth migration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds support for aborting in-flight requests, using the standardized
AbortSignalFixes #1761
This is the same as #2403, but for v8.x. I believe that both should be merged.
I've designed this as an additional parameter instead of mixing it with the body of the specific endpoint. I believe that this is a sounder approach as there will never be any conflicts, and it also avoids the current problem of
tokenalso being present in the request body as well as in the header when specified this way.Requirements
ping @zimeg who reviewed the v7 PR, and @WilliamBergamin who made the fetch switch, would love your 👀 on this 🙏