feat(custom-routes): expose query params on request object#2938
Open
singhvishalkr wants to merge 1 commit into
Open
feat(custom-routes): expose query params on request object#2938singhvishalkr wants to merge 1 commit into
singhvishalkr wants to merge 1 commit into
Conversation
Adds a query property to ParamsIncomingMessage that contains parsed query string parameters from the request URL. When a custom route handler receives a request like /greetings?name=you, the handler can access req.query.name. For repeated keys (/test?tags=a&tags=b), the value becomes an array instead of a single string. Fixes slackapi#2100
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Exposes query parameters to custom route handlers via req.query, similar to how Express.js handles them. When a request like /greetings?name=you comes in, the handler can access req.query.name directly.
Changes
Example
Requesting /greetings?name=you returns "Hello you!"
For repeated keys like /test?tags=a&tags=b, req.query.tags becomes ['a', 'b'].
Fixes #2100