chore(deps): make express an optional peer dependency#2815
chore(deps): make express an optional peer dependency#2815benmccann wants to merge 1 commit intoslackapi:mainfrom
Conversation
|
Thanks for the contribution! Before we can merge this, we need @benmccann to sign the Salesforce Inc. Contributor License Agreement. |
|
I have signed the CLA |
WilliamBergamin
left a comment
There was a problem hiding this comment.
Hi @benmccann thanks for bringing this up 💯
We need to make express a required peer dependency, making it an optional peer dependency might be considered a breaking change for some users, once resolved we should be good to merge
| "peerDependenciesMeta": { | ||
| "express": { | ||
| "optional": true | ||
| } |
There was a problem hiding this comment.
Since express is currently a dependency we can't make it an "optional" peerDependency since some users may be relying on it to transitively import express in their projects, this would cause a breaking change
Removing this section would make express a required peer-dependency (non-breaking change), this will allow users to explicitly exclude it from their projects with npm install --omit peer
Summary
closes #2814
Requirements (place an
xin each[ ])