Skip to content

make properties explicitly nullable #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maartenpaauw merged 2 commits into from
Apr 7, 2025
Merged

make properties explicitly nullable #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a14d9fe
made external id explicitly nullable
krb19xx Apr 5, 2025
9028ce6
fix: make constructor parameters explicitly nullable to avoid depreca…
maartenpaauw Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Exception.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ class Exception extends RuntimeException
/**
* @param array<string|int> $args
*/
public function __construct(string $message, array $args = [], Throwable $previous = null)
public function __construct(string $message, array $args = [], ?Throwable $previous = null)
{
$message = $args ? vsprintf($message, $args) : $message;

Expand Down
2 changes: 1 addition & 1 deletion src/Hydration/HydrationException.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ class HydrationException extends Exception
/**
* @param array<string|int> $args
*/
public function __construct(string $message, array $args = [], Throwable $previous = null)
public function __construct(string $message, array $args = [], ?Throwable $previous = null)
{
parent::__construct("FromArray Error: {$message}", $args, $previous);
}
Expand Down
2 changes: 1 addition & 1 deletion src/Kit.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ public static function divider(?string $blockId = null): Blocks\Divider
}

public static function file(
string $externalId = null,
?string $externalId = null,
?string $source = 'remote',
?string $blockId = null,
): Blocks\File {
Expand Down