Skip to content

fix(grid): Fix empty Grid menu button column header#3379

Merged
michal-sanoma merged 3 commits into
mainfrom
fix/2881_grid_empty_header
Jun 2, 2026
Merged

fix(grid): Fix empty Grid menu button column header#3379
michal-sanoma merged 3 commits into
mainfrom
fix/2881_grid_empty_header

Conversation

@michal-sanoma
Copy link
Copy Markdown
Collaborator

@michal-sanoma michal-sanoma commented May 22, 2026

Summary

This PR fixes the Grid/Basics/MenuButton story where the final menu button column rendered an empty table header

The menu button column now provides a visually hidden Actions header so assistive technologies can announce the purpose of the column while keeping the visual layout unchanged

Also updates the Grid header styling so .visually-hidden content can be used in any table header, not only the drag handle column

BEFORE

Screenshot 2026-05-22 at 18 02 46

AFTER

Screenshot 2026-05-22 at 18 03 55

@michal-sanoma michal-sanoma self-assigned this May 22, 2026
Copilot AI review requested due to automatic review settings May 22, 2026 16:02
@michal-sanoma michal-sanoma added the bug Something isn't working label May 22, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 22, 2026

🦋 Changeset detected

Latest commit: 0b18dfb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sl-design-system/grid Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@a11ymiko a11ymiko marked this pull request as ready for review May 25, 2026 10:39
Comment thread packages/components/grid/src/stories/basics.stories.ts Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

Copilot AI review requested due to automatic review settings June 2, 2026 10:51
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.

@michal-sanoma michal-sanoma merged commit a470889 into main Jun 2, 2026
14 checks passed
@michal-sanoma michal-sanoma deleted the fix/2881_grid_empty_header branch June 2, 2026 11:48
@github-actions github-actions Bot mentioned this pull request Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Grid - Basic] Menu button variant has empty table header

5 participants