Skip to content

SK-2675 fix date validation for month #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skyflow-bharti merged 4 commits into from
Mar 26, 2026
Merged

SK-2675 fix date validation for month #683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4c149f9
SK-2610 fix the type gap to pass the nested objects
skyflow-bharti Mar 12, 2026
9c7c544
SK-2675 fix the date validation
skyflow-bharti Mar 25, 2026
bdb7ae7
SK-2675 add unit test for fixing the date validation
skyflow-bharti Mar 25, 2026
f7c9575
SK-2675 undo style change
skyflow-bharti Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/utils/validators/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,14 +78,15 @@ export const validateExpiryDate = (date: string, format: string) => {
if (!date.includes('/')) return false;
const { month, year } = getYearAndMonthBasedOnFormat(date, format);
if (format.endsWith('YYYY') && year.toString().length !== 4) { return false; }
const monthNum = Number(month);
if (monthNum < 1 || monthNum > 12) { return false; }
const expiryDate = new Date(Number(year), Number(month), 0);
expiryDate.setHours(23, 59, 59, 999);
const today = new Date();

const maxDate = new Date();
maxDate.setFullYear(today.getFullYear() + 50);
maxDate.setMonth(today.getMonth() + 1);

return expiryDate >= today && expiryDate <= maxDate;
};

Expand Down
50 changes: 50 additions & 0 deletions tests/utils/validators.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,56 @@ describe('Validation card number and Expiry Date', () => {
expect(validateExpiryDate(expiryDate, "MM/YY")).toBe(false);
});

test('validate expiry date with month 00, MM/YY', () => {
const expiryDate = '00/45';
expect(validateExpiryDate(expiryDate, "MM/YY")).toBe(false);
});

test('validate expiry date with month 13, MM/YY', () => {
const expiryDate = '13/45';
expect(validateExpiryDate(expiryDate, "MM/YY")).toBe(false);
});

test('validate expiry date with month 00, YY/MM', () => {
const expiryDate = '45/00';
expect(validateExpiryDate(expiryDate, "YY/MM")).toBe(false);
});

test('validate expiry date with month 13, YY/MM', () => {
const expiryDate = '45/13';
expect(validateExpiryDate(expiryDate, "YY/MM")).toBe(false);
});

test('validate expiry date with month 00, YYYY/MM', () => {
const expiryDate = '2045/00';
expect(validateExpiryDate(expiryDate, "YYYY/MM")).toBe(false);
});

test('validate expiry date with month 13, YYYY/MM', () => {
const expiryDate = '2045/13';
expect(validateExpiryDate(expiryDate, "YYYY/MM")).toBe(false);
});

test('validate older expiry date with month 00, YYYY/MM', () => {
const expiryDate = '2024/00';
expect(validateExpiryDate(expiryDate, "YYYY/MM")).toBe(false);
});

test('validate older expiry date with month 13, YYYY/MM', () => {
const expiryDate = '2024/13';
expect(validateExpiryDate(expiryDate, "YYYY/MM")).toBe(false);
});

test('validate expiry date with month 00, MM/YYYY', () => {
const expiryDate = '00/2045';
expect(validateExpiryDate(expiryDate, "MM/YYYY")).toBe(false);
});

test('validate expiry date with month 13, MM/YYYY', () => {
const expiryDate = '13/2045';
expect(validateExpiryDate(expiryDate, "MM/YYYY")).toBe(false);
});

test('validate expired date, MM/YY', () => {
const currentDate = new Date();
const expiryDate = `${currentDate.getMonth()}/${currentDate.getFullYear().toString().slice(-2)}`;
Expand Down
Loading