Vendor dmsg e26b2982: fix ephemeral port leak + picomatch bump#2284
Merged
0pcom merged 1 commit intoskycoin:developfrom Apr 7, 2026
Merged
Vendor dmsg e26b2982: fix ephemeral port leak + picomatch bump#22840pcom merged 1 commit intoskycoin:developfrom
0pcom merged 1 commit intoskycoin:developfrom
Conversation
dmsg changes: - ClientSession.DialStream now accepts context.Context - When context is canceled, stream is closed immediately, freeing the reserved ephemeral port - Fix flaky TestHTTPTransport_RoundTrip (timeout + stabilization) - Server idle timeout on bridged streams (from previous vendor) skywire changes: - Fix api_dmsg.go DialStream call to pass context - Bump picomatch 2.3.1 -> 4.0.4 (dependabot security fix)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dmsg changes vendored
ClientSession.DialStreamnow acceptscontext.Context— when canceled, the stream is closed immediately, freeing the reserved ephemeral portTestHTTPTransport_RoundTriptestRoot cause of ephemeral port exhaustion
The setup-node's
NewClienthad a 30s dial timeout, butClientSession.DialStreamdidn't accept a context. When the timeout fired,readResponsekept blocking untilHandshakeTimeout, holding the ephemeral port. With 6 servers tried sequentially per dial, ports accumulated faster than they were freed.Test plan