Fix 2.2.0 router deployment selector migration#2467
Open
c-kruse wants to merge 2 commits into
Open
Conversation
)" This reverts commit fcb7f45.
PR skupperproject#2363 (released in 2.2.0) added skupper.io/group to the router Deployment's spec.selector. That change is reverted in 2.2.1+ because Deployment selectors are immutable: a 2.2.0 Site upgraded to a controller without the group label can never be patched in place breaking upgrades (issue skupperproject#2440). Detect the 2.2.0 selector at site recovery, and delete the stale Deployment with Background propagation. The next reconcile recreates it with the desired (pre-skupperproject#2363) selector. Signed-off-by: Christian Kruse <christian@c-kruse.com>
Contributor
Author
|
Have been working through testing. So far I've covered this - give me shout if I'm missing something that may be interesting. | Previous Controller Version | Controller Version | Result | I suggest that last case, a broken downgrade to 2.2.0 is something we have to accept and release note same as 2.1.3 -> 2.2.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves Issue #2440
Reverts the change to router Deployment selectors back to pre-2.2.0 state. Adds migration to fix 2.2.0 Deployments.