feat(fe): impl kakao login#3599
Open
dayeoni wants to merge 11 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new dedicated login page layout and component structure, replacing the previous modal-based login implementation. Feedback on the changes suggests improving responsiveness by replacing fixed widths and alignments with responsive Tailwind classes in both the login page and layout components. Additionally, it is recommended to clean up the codebase by removing the old login page code that was left commented out in the page file.
Comment on lines
+5
to
+69
| export default function Page() { | ||
| return <LogInPage /> | ||
| } | ||
|
|
||
| // 'use client' | ||
|
|
||
| // import { AuthModal } from '@/components/auth/AuthModal' | ||
| // import { | ||
| // Dialog, | ||
| // DialogContent, | ||
| // DialogHeader, | ||
| // DialogTitle | ||
| // } from '@/components/shadcn/dialog' | ||
| // import { useSession } from '@/libs/hooks/useSession' | ||
| // import { useAuthModalStore } from '@/stores/authModal' | ||
| // import type { Route } from 'next' | ||
| // import { useRouter, useSearchParams } from 'next/navigation' | ||
| // import { useEffect } from 'react' | ||
|
|
||
| // export default function LoginPage() { | ||
| // const { currentModal, hideModal, showSignIn } = useAuthModalStore( | ||
| // (state) => state | ||
| // ) | ||
| // const session = useSession() | ||
| // const router = useRouter() | ||
| // const searchParams = useSearchParams() | ||
|
|
||
| // useEffect(() => { | ||
| // showSignIn() | ||
| // }, [showSignIn]) | ||
|
|
||
| // useEffect(() => { | ||
| // if (session) { | ||
| // const redirectUrl = searchParams.get('redirectUrl') | ||
| // if (redirectUrl) { | ||
| // router.push(redirectUrl as Route) | ||
| // } else { | ||
| // router.push('/') | ||
| // } | ||
| // } | ||
| // }, [session, router, searchParams]) | ||
|
|
||
| // return ( | ||
| // <Dialog open={currentModal !== ''} onOpenChange={hideModal}> | ||
| // <DialogContent | ||
| // onOpenAutoFocus={(e) => { | ||
| // e.preventDefault() | ||
| // }} | ||
| // onInteractOutside={(e) => { | ||
| // e.preventDefault() | ||
| // }} | ||
| // onEscapeKeyDown={(e) => { | ||
| // e.preventDefault() | ||
| // }} | ||
| // hideCloseButton={true} | ||
| // className="!h-[620px] !w-[380px] rounded-[10px]" | ||
| // > | ||
| // <DialogHeader className="hidden"> | ||
| // <DialogTitle /> | ||
| // </DialogHeader> | ||
| // <AuthModal /> | ||
| // </DialogContent> | ||
| // </Dialog> | ||
| // ) | ||
| // } |
Contributor
There was a problem hiding this comment.
이전 로그인 페이지의 코드가 주석 처리된 채로 파일 하단에 남아 있습니다. Git 기록을 통해 이전 코드를 언제든지 추적하고 복구할 수 있으므로, 불필요한 주석 코드는 제거하여 파일의 가독성과 유지보수성을 높이는 것이 좋습니다.
Suggested change
| export default function Page() { | |
| return <LogInPage /> | |
| } | |
| // 'use client' | |
| // import { AuthModal } from '@/components/auth/AuthModal' | |
| // import { | |
| // Dialog, | |
| // DialogContent, | |
| // DialogHeader, | |
| // DialogTitle | |
| // } from '@/components/shadcn/dialog' | |
| // import { useSession } from '@/libs/hooks/useSession' | |
| // import { useAuthModalStore } from '@/stores/authModal' | |
| // import type { Route } from 'next' | |
| // import { useRouter, useSearchParams } from 'next/navigation' | |
| // import { useEffect } from 'react' | |
| // export default function LoginPage() { | |
| // const { currentModal, hideModal, showSignIn } = useAuthModalStore( | |
| // (state) => state | |
| // ) | |
| // const session = useSession() | |
| // const router = useRouter() | |
| // const searchParams = useSearchParams() | |
| // useEffect(() => { | |
| // showSignIn() | |
| // }, [showSignIn]) | |
| // useEffect(() => { | |
| // if (session) { | |
| // const redirectUrl = searchParams.get('redirectUrl') | |
| // if (redirectUrl) { | |
| // router.push(redirectUrl as Route) | |
| // } else { | |
| // router.push('/') | |
| // } | |
| // } | |
| // }, [session, router, searchParams]) | |
| // return ( | |
| // <Dialog open={currentModal !== ''} onOpenChange={hideModal}> | |
| // <DialogContent | |
| // onOpenAutoFocus={(e) => { | |
| // e.preventDefault() | |
| // }} | |
| // onInteractOutside={(e) => { | |
| // e.preventDefault() | |
| // }} | |
| // onEscapeKeyDown={(e) => { | |
| // e.preventDefault() | |
| // }} | |
| // hideCloseButton={true} | |
| // className="!h-[620px] !w-[380px] rounded-[10px]" | |
| // > | |
| // <DialogHeader className="hidden"> | |
| // <DialogTitle /> | |
| // </DialogHeader> | |
| // <AuthModal /> | |
| // </DialogContent> | |
| // </Dialog> | |
| // ) | |
| // } | |
| export default function Page() { | |
| return <LogInPage /> | |
| } |
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
[화이트리스트 제거] 로그인 페이지 작업
🔴아직 진행중인 작업입니다
Additional context
로그인 페이지에 대한 작업
[피그마 버전 완성본]
[현재 작업 완료 상황]
[진행 상황]
closes TAS-2728
Before submitting the PR, please make sure you do the following
fixes #123).