feat(infra): configure default load test environment#3584
Open
tasoo-oos wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for configuring load tests via a .env file, reducing the default load and allowing users to customize the number of virtual users (VUs) and ramp-up/steady/ramp-down durations. However, there is a critical issue in submission-load.js where open('./.env') is evaluated statically by k6 during initialization. If the .env file does not exist, k6 will throw a fatal error and crash before the try...catch block can execute, which breaks execution when only using environment variables.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
K6 기반 로드테스트에서 사용될 기본 세팅을 .env.example에 넣었습니다.
Additional context
Closes TAS-2724
Before submitting the PR, please make sure you do the following
fixes #123).