Skip to content

docs(be): add JSDoc into AssignmentProblemService#3360

Merged
RyuRaseul merged 10 commits intomainfrom
t2441-add-JSDoc-into-assignment-problem-service
Feb 5, 2026
Merged

docs(be): add JSDoc into AssignmentProblemService#3360
RyuRaseul merged 10 commits intomainfrom
t2441-add-JSDoc-into-assignment-problem-service

Conversation

@nhjbest22
Copy link
Copy Markdown
Contributor

@nhjbest22 nhjbest22 commented Jan 20, 2026

Description

AssignmentProblemService의 함수들의 역할을 명확히하기 위해 JSDoc을 추가했습니다.

Additional context

  • 추가적인 리팩토링을 수행하였습니다.
  1. 불필요한 Return Type 지정을 삭제하였습니다.
    다음을 참고하였습니다. 불필요한 Type을 피해요.
  2. return시에 사용되는 불필요한 await 문을 삭제하였습니다.
  3. select를 사용해 실제 사용되는 column만을 가져올 수 있도록 하였습니다.

Closes TAS-2441

Before submitting the PR, please make sure you do the following

@nhjbest22 nhjbest22 self-assigned this Jan 20, 2026
@github-project-automation github-project-automation Bot moved this to Pending ✋ in Codedang Jan 20, 2026
@skkuding-bot
Copy link
Copy Markdown

skkuding-bot Bot commented Jan 20, 2026

Syncing Preview App Succeeded

Application: frontend
Revision: 91ef8565c811eb96acb8305aa60a6d8183ef5fa9
Health Status: Healthy

Open Preview | View in Argo CD

@nhjbest22 nhjbest22 changed the title feat(be): add JSDoc into AssignmentProblemService docs(be): add JSDoc into AssignmentProblemService Jan 20, 2026
@notion-task-integration
Copy link
Copy Markdown

notion-task-integration Bot commented Jan 20, 2026

@nhjbest22 nhjbest22 moved this from Pending ✋ to Review PLZ 🙏 in Codedang Jan 20, 2026
@nhjbest22 nhjbest22 requested a review from RyuRaseul January 29, 2026 11:59
Comment thread apps/backend/apps/admin/src/assignment/assignment-problem.service.ts Outdated
Comment thread apps/backend/apps/admin/src/assignment/assignment-problem.service.ts Outdated
Copy link
Copy Markdown
Contributor

@RyuRaseul RyuRaseul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-project-automation github-project-automation Bot moved this from Review PLZ 🙏 to Approved 👌 in Codedang Feb 5, 2026
@RyuRaseul RyuRaseul enabled auto-merge February 5, 2026 07:50
@skkuding-bot
Copy link
Copy Markdown

skkuding-bot Bot commented Feb 5, 2026

Syncing Preview App Succeeded

Application: frontend
Revision: f2f0670c24d145a800d0ab405fec276e7541f762
Health Status: Healthy

Open Preview | View in Argo CD

@RyuRaseul RyuRaseul added this pull request to the merge queue Feb 5, 2026
Merged via the queue into main with commit 0e05bd3 Feb 5, 2026
11 checks passed
@RyuRaseul RyuRaseul deleted the t2441-add-JSDoc-into-assignment-problem-service branch February 5, 2026 08:01
@github-project-automation github-project-automation Bot moved this from Approved 👌 to Done ✔️ in Codedang Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done ✔️

Development

Successfully merging this pull request may close these issues.

2 participants