doctor: log process failures#176
Closed
dfabulich wants to merge 1 commit intoskiptools:mainfrom
Closed
Conversation
marcprux
reviewed
Feb 4, 2026
|
|
||
| func parseVersion(_ result: Result<ProcessOutput, Error>?) -> (result: Result<ProcessOutput, Error>?, message: MessageBlock?) { | ||
| if let result = result, case .failure(let error) = result { | ||
| self.outputOptions.logMessage("\(title): \(error)") |
Member
There was a problem hiding this comment.
What is the benefit of logging the message in addition to returning the failed result along with the MessageBlock with the failure details? We generally prefer to include all the relevant data in the MessageBlock so it can be accessed through the skip doctor --json output by a (theoretical) tool that might be running the command.
Contributor
Author
There was a problem hiding this comment.
I'm open minded as to exactly how to fix it, but, today, if skip doctor tries to run a command that simply doesn't exist, nothing shows up in the log at all.
Contributor
Author
|
I can't repro the issue I was trying to fix here; we have a separate code path for ADB, the one most likely to blow up here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip Pull Request Checklist:
swift test