add .trim shape modifier

[vincentborko]

Thank you for contributing to the Skip project! Please use this space to describe your change and add any labels (bug, enhancement, documentation, etc.) to help categorize your contribution.

Skip Pull Request Checklist:

• REQUIRED: I have signed the Contributor Agreement
• REQUIRED: I have tested my change locally with swift test
• OPTIONAL: I have tested my change on an iOS simulator or device
• OPTIONAL: I have tested my change on an Android emulator or device
• REQUIRED: I have checked whether this change requires a corresponding update in the Skip Fuse UI repository (link related PR if applicable)
• OPTIONAL: I have added an example of any UI changes in the Showcase sample app

[marcprux]

The demo added in skiptools/skipapp-showcase-fuse#42 is showing the trim paths all reversed between the iOS and Android builds. Do you see this as well?

[marcprux]

Any thoughts on this, @vincentborko? I'd love to get this merged if we can fix the reversal issue…

[vincentborko]

Sorry, I didn't see the previous reply, I was very busy with another project of mine. I'll try to look into it ASAP to fix it latest on the weekend.

IIRC I might have implemented a custom trim especially for circles, with might be worth commenting out to try the generic approach.
Edit: Nvm, the issue is with all the shapes you showed in screenshot, not only circles

[vincentborko]

compose's addOval, addRect, addRoundRect use internally android.graphics.Path.Direction.CCW, while swiftUI creates path clockwise. apparently this didn't matter for anything besides the new trim and animations. we could either accept the difference as its "native" as I think, or manually update the path functions to overwrite them with clockwise drawing. do you want me to update it to match SwiftUI?

[marcprux]

Yeah, I think the Compose needs to match the SwiftUI in this case. Is there some handy "invert trim path" method somewhere that could be used?

[vincentborko]

ive updated it.

[marcprux]

Great! Glad it was so simple 😄

[vincentborko]

sure thing.
if you want, I can merge the newanimationplayground into animationplayground

[marcprux]

Yes please, that'd be great!