Skip to content

Fix skale passive node options #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexgex merged 1 commit into from
Dec 29, 2025
Merged

Fix skale passive node options #953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion helper-scripts
Open in desktop
Submodule helper-scripts updated 5 files
+1 −1 deploy_allocator.sh
+3 −3 deploy_fair.sh
+1 −1 deploy_ima.sh
+1 −1 deploy_manager.sh
+15 −5 helper.sh
2 changes: 1 addition & 1 deletion node_cli/operations/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ def update_passive(env_filepath: str, env: Dict) -> bool:
meta_manager.update_meta(
VERSION,
env['NODE_VERSION'],
env['DOCKER_LVMPY_VERSION'],
None,
distro.id(),
distro.version(),
)
Expand Down
5 changes: 1 addition & 4 deletions node_cli/utils/docker_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,7 @@
'boot-api': 'sk_boot_api',
}

BASE_PASSIVE_COMPOSE_SERVICES = {
'admin': 'sk_admin',
'nginx': 'sk_nginx',
}
BASE_PASSIVE_COMPOSE_SERVICES = {'admin': 'sk_admin', 'nginx': 'sk_nginx', **REDIS_SERVICE_DICT}

BASE_PASSIVE_FAIR_COMPOSE_SERVICES = {
'admin': 'sk_admin',
Expand Down
2 changes: 1 addition & 1 deletion node_cli/utils/meta.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ def asdict(self) -> dict:

@dataclass
class CliMeta(CliMetaBase):
docker_lvmpy_version: str = DEFAULT_DOCKER_LVMPY_VERSION
docker_lvmpy_version: str | None = DEFAULT_DOCKER_LVMPY_VERSION

def asdict(self) -> dict:
return {
Expand Down