Bump vendored compare bundle: VisualProgress-keyed filmstrip#238
Merged
Conversation
Picks up the upstream fix (sitespeedio/compare#171) for filmstrip 404s in the compare view. The previous bundle constructed frame URLs on a fixed 100 ms cadence inside (FVC, LVC), which broke on any run where visual progress went flat between two boundaries — the expected JPGs were never written, so the strip showed broken cells. The upstream pass now reads the frame timestamps straight from _visualMetrics.VisualProgress (one JPG per VP sample, named after that exact ms), and lets the existing 100 ms padding step forward-fill the uniform grid so the rendered strip still reads "nothing happened for 2 s" differently from "everything changed in 50 ms". Co-authored-by: Claude Opus 4.7 (1M context) noreply@anthropic.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up the upstream fix (sitespeedio/compare#171) for filmstrip
404s in the compare view. The previous bundle constructed frame URLs
on a fixed 100 ms cadence inside (FVC, LVC), which broke on any run
where visual progress went flat between two boundaries — the
expected JPGs were never written, so the strip showed broken cells.
The upstream pass now reads the frame timestamps straight from
_visualMetrics.VisualProgress (one JPG per VP sample, named after
that exact ms), and lets the existing 100 ms padding step
forward-fill the uniform grid so the rendered strip still reads
"nothing happened for 2 s" differently from "everything changed
in 50 ms".
Co-authored-by: Claude Opus 4.7 (1M context) noreply@anthropic.com