Stop terser from negating the coach IIFE's return value#177
Merged
Conversation
The minified coach script is invoked in the browser via Selenium's
executeScript by way of return ${script}, so the outer IIFE's return
value IS the contract — sitespeed.io reads it back as
browserScriptsData.coach.coachAdvice and expects an object with the
collected advice, errors and version.
Terser's negate_iife compress option rewrites a top-level
(function(){…})() as !function(){…}() to shave a byte. That turned
the advice object into false on the wire. The bug was latent: an old
--compresss typo meant compression never ran, so the negation never
happened. Once that typo was fixed (dd178ab) compression kicked in and
sitespeed.io started seeing coachAdvice === false, then crashing the
DOM/HAR merge and the html templates that assume DOM data exists.
Disable negate_iife in the terser invocation so the IIFE keeps its
return value.
Co-authored-by: Claude Opus 4.7 (1M context) noreply@anthropic.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The minified coach script is invoked in the browser via Selenium's
executeScript by way of return ${script}, so the outer IIFE's return
value IS the contract — sitespeed.io reads it back as
browserScriptsData.coach.coachAdvice and expects an object with the
collected advice, errors and version.
Terser's negate_iife compress option rewrites a top-level
(function(){…})() as !function(){…}() to shave a byte. That turned
the advice object into false on the wire. The bug was latent: an old
--compresss typo meant compression never ran, so the negation never
happened. Once that typo was fixed (dd178ab) compression kicked in and
sitespeed.io started seeing coachAdvice === false, then crashing the
DOM/HAR merge and the html templates that assume DOM data exists.
Disable negate_iife in the terser invocation so the IIFE keeps its
return value.
Co-authored-by: Claude Opus 4.7 (1M context) noreply@anthropic.com