Fix the terser script and drop the unrunnable eslint-check script#173
Merged
Conversation
The terser script was running with --compresss (three s's). Terser silently treated the typo as an unknown flag and skipped compression entirely, so the shipped coach.min.js was mangled-only. Correcting it to --compress shrinks the bundle from 54,739 to 52,739 bytes — a ~2 KB win on every release with zero behaviour change. The eslint-check script was a relic: it pipes the output of eslint --print-config .eslintrc.js (the file is now eslint.config.cjs) into eslint-config-prettier-check, a binary that modern eslint-config-prettier no longer ships. The script could not run; dropping it removes confusion. Co-authored-by: Claude noreply@anthropic.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The terser script was running with --compresss (three s's). Terser silently
treated the typo as an unknown flag and skipped compression entirely, so the
shipped coach.min.js was mangled-only. Correcting it to --compress shrinks
the bundle from 54,739 to 52,739 bytes — a ~2 KB win on every release with
zero behaviour change.
The eslint-check script was a relic: it pipes the output of eslint --print-config .eslintrc.js (the file is now
eslint.config.cjs) into
eslint-config-prettier-check, a binary that modern eslint-config-prettier
no longer ships. The script could not run; dropping it removes confusion.
Co-authored-by: Claude noreply@anthropic.com