Migrate to PHPCSUtils #360
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been many years since it was suggested to use PHPCSUtils to simplify the helpers used by this sniff (see discussion in #214 and #149 and #132 and probably others).
Originally I had held off because PHPCSUtils had not stabilized, but it is definitely stable now.
I've finally decided to try the migration to see what benefits it could provide.
This PR is the first step in that process that should eventually lead to 3.0.
Warning
Do not merge this into the 2.x branch! It changes the minimum supported versions of phpcs and adds a new dependency!