feat: add query margin mode endpoint#101
Open
MolhamHamwi wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for querying the current swap margin mode via the BingX REST API, wiring a new endpoint into the client TradeService and exporting it for public consumption.
Changes:
- Added
BingxQueryMarginModeEndpointforGET /openApi/swap/v2/trade/marginType - Exposed the endpoint via
TradeService.queryMarginMode(symbol, account) - Exported the endpoint from the endpoints barrel and added unit tests for endpoint metadata and service wiring
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/bingx/endpoints/index.ts | Re-exports the new query margin mode endpoint. |
| src/bingx/endpoints/bingx-query-margin-mode-endpoint.ts | Implements the new signed GET endpoint and response typing. |
| src/bingx-client/services/trade.service.ts | Adds queryMarginMode(...) to execute the new endpoint. |
| src/bingx-client/services/trade.service.spec.ts | Adds unit tests validating endpoint metadata and service dispatch. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+88
to
+92
| public queryMarginMode(symbol: string, account: AccountInterface) { | ||
| return this.requestExecutor.execute( | ||
| new BingxQueryMarginModeEndpoint(symbol, account), | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BingxQueryMarginModeEndpointforGET /openApi/swap/v2/trade/marginTypeTradeService.queryMarginMode(...)Closes #86
Validation
npm test -- --runInBand trade.service.spec.tsnpm run build./node_modules/.bin/eslint src/bingx/endpoints/bingx-query-margin-mode-endpoint.ts src/bingx-client/services/trade.service.ts src/bingx-client/services/trade.service.spec.ts