fix malformed URL causing 'since' filter to be dropped for Issues and Comments streams#230
Open
leslievandemark wants to merge 4 commits into
Open
fix malformed URL causing 'since' filter to be dropped for Issues and Comments streams#230leslievandemark wants to merge 4 commits into
leslievandemark wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
build_urlalways appended?since=to the URL, but the Issues and Comments stream paths already contain a query string (e.g.issues?state=all&sort=updated&direction=desc). This produced a malformed URL with a double ?:/issues?state=all&sort=updated&direction=desc?since=2026-04-30T16:55:02ZGitHub parses everything after the first ? as the query string, so direction received the value
desc?since=...(invalid) andsincewas never recognized as a parameter. With direction malformed, GitHub could return records in ascending order — causingIncrementalOrderedStreamto hitsynced_all_records = Trueon the first old record and drop all recently updated issues.Manual QA steps
Risks
Rollback steps
AI generated code
https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code