Skip to content

fix malformed URL causing 'since' filter to be dropped for Issues and Comments streams#230

Open
leslievandemark wants to merge 4 commits into
masterfrom
fix-malformed-url-bug
Open

fix malformed URL causing 'since' filter to be dropped for Issues and Comments streams#230
leslievandemark wants to merge 4 commits into
masterfrom
fix-malformed-url-bug

Conversation

@leslievandemark
Copy link
Copy Markdown
Contributor

@leslievandemark leslievandemark commented May 12, 2026

Description of change

build_url always appended ?since= to the URL, but the Issues and Comments stream paths already contain a query string (e.g. issues?state=all&sort=updated&direction=desc). This produced a malformed URL with a double ?:
/issues?state=all&sort=updated&direction=desc?since=2026-04-30T16:55:02Z

GitHub parses everything after the first ? as the query string, so direction received the value desc?since=... (invalid) and since was never recognized as a parameter. With direction malformed, GitHub could return records in ascending order — causing IncrementalOrderedStream to hit synced_all_records = True on the first old record and drop all recently updated issues.

Manual QA steps

  • Ran the tap, updated an Issue and saw that it was not replicated
  • Ran new code, verified the updated Issue was replicated.

Risks

Rollback steps

  • revert this branch

AI generated code

https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code

  • this PR has been written with the help of GitHub Copilot or another generative AI tool

@leslievandemark leslievandemark changed the title fix malformed URL causing 'since' filter to be dropped for Issues and Comments streams fix malformed URL causing 'since' filter to be dropped for Issues stream May 12, 2026
@leslievandemark leslievandemark changed the title fix malformed URL causing 'since' filter to be dropped for Issues stream fix malformed URL causing 'since' filter to be dropped for Issues and Comments streams May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant