fix: make env value type unknown#1217
Closed
dword-design wants to merge 2 commits intosindresorhus:mainfrom
Closed
fix: make env value type unknown#1217dword-design wants to merge 2 commits intosindresorhus:mainfrom
dword-design wants to merge 2 commits intosindresorhus:mainfrom
Conversation
Collaborator
|
Hi @dword-design, This makes sense to me. Although arguably, some might consider relying on implicit transtyping to be bad practice, do we still want to allow it with our types? What are your thoughts on this @sindresorhus? |
Owner
|
It's intentionally strict. That's the point of using TS. Lots of things are implicitly coerced in JS, but the types should not reflect that. So I would not merge this. |
Author
|
It's fine for me not to merge it. At least the discussion is here in case there are people asking. Alternatively, I thought about having the primitive types like |
Collaborator
|
Thanks for your understanding @dword-design. 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently only
stringis allowed as values forenv. But the variables will be stringified by Node.js, so actually anything can be passed.I removed a test that imho isn't needed anymore. Alternatively, env could get a generic type arg, but as long as the type isn't used in any way in the lib, there isn't a need for it imho.