Skip to content

DEVEXP-794: Conversation Messages - Unit Tests I #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matsk-sinch merged 4 commits into from
Jan 20, 2026
Merged

DEVEXP-794: Conversation Messages - Unit Tests I #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
616ed27
DEVEXP-794: Conversation Messages - Unit Tests I
matsk-sinch Jan 19, 2026
77fcd60
Update tests/unit/domains/conversation/v1/models/response/app_message…
matsk-sinch Jan 20, 2026
c92ffb1
Update tests/unit/domains/conversation/v1/models/response/app_message…
matsk-sinch Jan 20, 2026
e97e88d
refine unit test
matsk-sinch Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sinch/domains/conversation/models/v1/messages/categories/contactinfo/contact_info_message.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
from typing import Optional
from datetime import date
from pydantic import Field, conlist
from sinch.domains.conversation.models.v1.messages.internal.base import (
BaseModelConfigurationResponse,
Expand Down Expand Up @@ -40,6 +41,6 @@ class ContactInfoMessage(BaseModelConfigurationResponse):
urls: Optional[conlist(UrlInfo)] = Field(
default=None, description="URLs/websites associated with the contact."
)
birthday: Optional[str] = Field(
birthday: Optional[date] = Field(
default=None, description="Date of birth in YYYY-MM-DD format."
)
4 changes: 2 additions & 2 deletions sinch/domains/conversation/models/v1/messages/response/types/app_message.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@
CardAppMessage,
CarouselAppMessage,
ChoiceAppMessage,
ContactInfoAppMessage,
ListAppMessage,
LocationAppMessage,
MediaAppMessage,
TemplateAppMessage,
TextAppMessage,
ListAppMessage,
ContactInfoAppMessage,
]
193 changes: 8 additions & 185 deletions tests/unit/domains/conversation/v1/endpoints/messages/test_get_message_endpoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,15 @@
import pytest
from datetime import datetime, timezone
from sinch.core.models.http_response import HTTPResponse
from sinch.domains.conversation.api.v1.internal import GetMessageEndpoint
from sinch.domains.conversation.models.v1.messages.internal.request import MessageIdRequest
from sinch.domains.conversation.models.v1.messages.response.message_response import (
AppMessageResponse,
ContactMessageResponse,
)
from tests.unit.domains.conversation.v1.models.response.test_conversation_message_response_model import (
contact_message_response_data,
app_message_response_data,
)


@pytest.fixture
Expand All @@ -15,138 +18,21 @@ def request_data():


@pytest.fixture
def mock_contact_message_response():
def mock_contact_message_response(contact_message_response_data):
"""Mock response for ContactMessageResponse (Union type test)."""
return HTTPResponse(
status_code=200,
body={
"id": "CAPY123456789ABCDEFGHIJKLMNOP",
"conversation_id": "CONV987654321ZYXWVUTSRQPONMLK",
"contact_id": "CONTACT456789ABCDEFGHIJKLMNOPQR",
"direction": "UNDEFINED_DIRECTION",
"channel_identity": {
"app_id": "APP123456789ABCDEFGHIJK",
"channel": "WHATSAPP",
"identity": "+46701234567"
},
"metadata": "test_metadata",
"accept_time": "2026-01-14T20:32:31.147Z",
"injected": True,
"sender_id": "SENDER123456789ABCDEFGHIJK",
"processing_mode": "CONVERSATION",
"contact_message": {
"channel_specific_message": {
"message_type": "nfm_reply",
"message": {
"type": "nfm_reply",
"nfm_reply": {
"name": "flow",
"response_json": "{\"key\": \"value\"}",
"body": "Message body text"
}
}
},
"reply_to": {
"message_id": "REPLY_TO_MSG123456789ABCDEF"
}
}
},
body=contact_message_response_data,
headers={"Content-Type": "application/json"},
)


@pytest.fixture
def mock_app_message_response():
def mock_app_message_response(app_message_response_data):
"""Mock response for AppMessageResponse (Union type test)."""
return HTTPResponse(
status_code=200,
body={
"id": "APP123456789ABCDEFGHIJKLMNOP",
"conversation_id": "CONV987654321ZYXWVUTSRQPONMLK",
"contact_id": "CONTACT456789ABCDEFGHIJKLMNOPQR",
"direction": "UNDEFINED_DIRECTION",
"channel_identity": {
"app_id": "APP123456789ABCDEFGHIJK",
"channel": "WHATSAPP",
"identity": "+46701234567"
},
"metadata": "test_metadata",
"accept_time": "2026-01-14T20:32:31.147Z",
"injected": True,
"sender_id": "SENDER123456789ABCDEFGHIJK",
"processing_mode": "CONVERSATION",
"app_message": {
"card_message": {
"choices": [
{
"call_message": {
"phone_number": "+15551231234",
"title": "Message text"
},
"postback_data": None
}
],
"description": "Card description text",
"height": "UNSPECIFIED_HEIGHT",
"title": "Card title",
"media_message": {
"thumbnail_url": "https://example.com/thumbnail.jpg",
"url": "https://example.com/media.jpg",
"filename_override": "custom_filename.jpg"
},
"message_properties": {
"whatsapp_header": "WhatsApp header text"
}
},
"explicit_channel_message": {
"property1": "string",
"property2": "string"
},
"explicit_channel_omni_message": {
"property1": {
"text_message": {
"text": "string"
}
},
"property2": {
"text_message": {
"text": "string"
}
}
},
"channel_specific_message": {
"property1": {
"message_type": "FLOWS",
"message": {
"header": {
"type": "text",
"text": "string"
},
"body": {
"text": "string"
},
"footer": {
"text": "string"
},
"flow_id": "string",
"flow_token": "string",
"flow_mode": "draft",
"flow_cta": "string",
"flow_action": "navigate",
"flow_action_payload": {
"screen": "string",
"data": {}
}
}
}
},
"agent": {
"display_name": "Agent Name",
"type": "UNKNOWN_AGENT_TYPE",
"picture_url": "https://example.com/agent.jpg"
}
}
},
body=app_message_response_data,
headers={"Content-Type": "application/json"},
)

Expand Down Expand Up @@ -191,32 +77,6 @@ def test_handle_response_expects_contact_message_response(endpoint, mock_contact
assert isinstance(parsed_response, ContactMessageResponse)
assert not isinstance(parsed_response, AppMessageResponse)

assert parsed_response.id == "CAPY123456789ABCDEFGHIJKLMNOP"
assert parsed_response.conversation_id == "CONV987654321ZYXWVUTSRQPONMLK"
assert parsed_response.contact_id == "CONTACT456789ABCDEFGHIJKLMNOPQR"
assert parsed_response.direction == "UNDEFINED_DIRECTION"
assert parsed_response.metadata == "test_metadata"
assert parsed_response.contact_message is not None
assert parsed_response.contact_message.channel_specific_message is not None
assert parsed_response.contact_message.channel_specific_message.message_type == "nfm_reply"
assert parsed_response.contact_message.channel_specific_message.message.type == "nfm_reply"
assert parsed_response.contact_message.channel_specific_message.message.nfm_reply.name == "flow"
assert parsed_response.contact_message.channel_specific_message.message.nfm_reply.response_json == "{\"key\": \"value\"}"
assert parsed_response.contact_message.channel_specific_message.message.nfm_reply.body == "Message body text"
assert parsed_response.contact_message.reply_to is not None
assert parsed_response.contact_message.reply_to.message_id == "REPLY_TO_MSG123456789ABCDEF"
assert parsed_response.channel_identity is not None
assert parsed_response.channel_identity.app_id == "APP123456789ABCDEFGHIJK"
assert parsed_response.channel_identity.channel == "WHATSAPP"
assert parsed_response.channel_identity.identity == "+46701234567"
assert parsed_response.injected is True
assert parsed_response.sender_id == "SENDER123456789ABCDEFGHIJK"
assert parsed_response.processing_mode == "CONVERSATION"

assert parsed_response.accept_time == datetime(
2026, 1, 14, 20, 32, 31, 147000, tzinfo=timezone.utc
)


def test_handle_response_expects_app_message_response(mock_app_message_response):
"""
Expand All @@ -231,40 +91,3 @@ def test_handle_response_expects_app_message_response(mock_app_message_response)
# In this test case, we expect an AppMessageResponse
assert isinstance(parsed_response, AppMessageResponse)
assert not isinstance(parsed_response, ContactMessageResponse)

assert parsed_response.id == "APP123456789ABCDEFGHIJKLMNOP"
assert parsed_response.conversation_id == "CONV987654321ZYXWVUTSRQPONMLK"
assert parsed_response.contact_id == "CONTACT456789ABCDEFGHIJKLMNOPQR"
assert parsed_response.direction == "UNDEFINED_DIRECTION"
assert parsed_response.metadata == "test_metadata"
assert parsed_response.app_message is not None
assert parsed_response.app_message.card_message is not None
assert parsed_response.app_message.card_message.title == "Card title"
assert parsed_response.app_message.card_message.description == "Card description text"
assert parsed_response.app_message.card_message.height == "UNSPECIFIED_HEIGHT"
assert parsed_response.app_message.card_message.choices is not None
assert len(parsed_response.app_message.card_message.choices) == 1
assert parsed_response.app_message.card_message.choices[0].call_message is not None
assert parsed_response.app_message.card_message.choices[0].call_message.phone_number == "+15551231234"
assert parsed_response.app_message.card_message.choices[0].call_message.title == "Message text"
assert parsed_response.app_message.card_message.media_message is not None
assert parsed_response.app_message.card_message.media_message.url == "https://example.com/media.jpg"
assert parsed_response.app_message.card_message.media_message.thumbnail_url == "https://example.com/thumbnail.jpg"
assert parsed_response.app_message.card_message.media_message.filename_override == "custom_filename.jpg"
assert parsed_response.app_message.card_message.message_properties is not None
assert parsed_response.app_message.card_message.message_properties.whatsapp_header == "WhatsApp header text"
assert parsed_response.app_message.agent is not None
assert parsed_response.app_message.agent.display_name == "Agent Name"
assert parsed_response.app_message.agent.type == "UNKNOWN_AGENT_TYPE"
assert parsed_response.app_message.agent.picture_url == "https://example.com/agent.jpg"
assert parsed_response.channel_identity is not None
assert parsed_response.channel_identity.app_id == "APP123456789ABCDEFGHIJK"
assert parsed_response.channel_identity.channel == "WHATSAPP"
assert parsed_response.channel_identity.identity == "+46701234567"
assert parsed_response.injected is True
assert parsed_response.sender_id == "SENDER123456789ABCDEFGHIJK"
assert parsed_response.processing_mode == "CONVERSATION"

assert parsed_response.accept_time == datetime(
2026, 1, 14, 20, 32, 31, 147000, tzinfo=timezone.utc
)
Loading