Skip to content

[Mage] AC benefits Pulse's cast time #11181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pinepinepinepinepine wants to merge 4 commits into
base: midnight
Choose a base branch
from
Open

[Mage] AC benefits Pulse's cast time #11181

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f760401
pulse benefits from ac
pinepinepinepinepine Mar 14, 2026
3a6ee47
revert this if it's not preferable
pinepinepinepinepine Mar 14, 2026
77c2692
i don't know if this is more preferable than the other commit (which …
pinepinepinepinepine Mar 14, 2026
1115077
just a happy friendly comment, no preference stuff.
pinepinepinepinepine Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion engine/class_modules/sc_mage.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2945,9 +2945,11 @@ struct arcane_explosion_t final : public arcane_mage_spell_t
struct arcane_pulse_t final : public arcane_mage_spell_t
{
action_t* arcane_pulse_echo = nullptr;
const bool ac_affects_cast; // Delete whenever 12.0.5 goes live.

arcane_pulse_t( std::string_view n, mage_t* p, std::string_view options_str, bool echo = false ) :
arcane_mage_spell_t( n, p, echo ? p->find_spell( 1243460 ) : p->talents.arcane_pulse )
arcane_mage_spell_t( n, p, echo ? p->find_spell( 1243460 ) : p->talents.arcane_pulse ),
ac_affects_cast( data().affected_by( p->buffs.arcane_charge->data().effectN( 4 ) ) )
{
parse_options( options_str );
aoe = -1;
Expand Down Expand Up @@ -3010,6 +3012,17 @@ struct arcane_pulse_t final : public arcane_mage_spell_t

return am;
}

double execute_time_pct_multiplier() const override
{
double mul = arcane_mage_spell_t::execute_time_pct_multiplier();

// Unmentioned by tooltip
if ( ac_affects_cast )
mul *= 1.0 + p()->buffs.arcane_charge->check() * p()->buffs.arcane_charge->data().effectN( 4 ).percent();

return mul;
}
};

struct arcane_assault_t final : public arcane_mage_spell_t
Expand Down
Loading