Skip to content

[Deathknight] Adjust DRW damage reporting #10739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Armadk merged 1 commit into from
Jan 5, 2026
+1 −9
Merged

[Deathknight] Adjust DRW damage reporting #10739

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions engine/class_modules/sc_death_knight.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1769,7 +1769,7 @@ struct death_knight_t : public parse_player_effects_t
: ghoul_pet( "ghoul", p ),
dancing_rune_weapon_pet( "dancing_rune_weapon", p ),
everlasting_bond_pet( "everlasting_bond", p ),
dance_of_midnight_pet( "dance_of_midnight_pet", p ),
dance_of_midnight_pet( "dance_of_midnight", p ),
bloodworms( "bloodworm", p ),
lesser_ghoul_army( "lesser_ghoul_army", p ),
lesser_ghoul_db_coil( "lesser_ghoul_db_coil", p ),
Expand Down Expand Up @@ -9147,14 +9147,6 @@ struct dancing_rune_weapon_t final : public death_knight_spell_t
parse_options( options_str );

p->pets.dancing_rune_weapon_pet.set_creation_event_callback( pets::parent_pet_action_fn( this ) );
if ( p->talent.blood.everlasting_bond.ok() )
{
p->pets.everlasting_bond_pet.set_creation_event_callback( pets::parent_pet_action_fn( this ) );
}

// Consider moving this to it's own action
if ( p->talent.blood.dance_of_midnight_3.ok() )
p->pets.dance_of_midnight_pet.set_creation_event_callback( pets::parent_pet_action_fn( this ) );
}

void execute() override
Expand Down
Loading